spoorn / sodium-forge

A Fabric..... I mean Forge mod designed to improve frame rates and reduce micro-stutter
GNU Lesser General Public License v3.0
28 stars 8 forks source link

Darkness Everywhere #70

Closed WenXin20 closed 3 years ago

WenXin20 commented 3 years ago

Expected Behavior

Actual Behavior

Reproduction Steps

  1. Join a server world
  2. Observe

Attachments

2021-07-04_18 28 40 2021-07-04_18 29 06

[Optional] Server/Client logs

Mods list

System Information

spoorn commented 3 years ago

Can you confirm if it's related to something with the Lithium mixins by setting mixin.ai=true in the sodium-mixins.properties file?

spoorn commented 3 years ago

You could also try editing some of the menu options, like Smooth Lighting and see if turning off Smooth Lighting fixes it

WenXin20 commented 3 years ago

Sure, I'll give it a try

WenXin20 commented 3 years ago

Tried both, but neither one fixed it. Just thought to mention that the F3 screen displays the light level at zero. Also noticed that Biome Blend is stuck at 2 for me, tried changing it to 7, but it reset after closing the menu using esc (close button didn't work either).

No smooth lightning: 2021-07-05_01 01 25

spoorn commented 3 years ago

hmm, it could be a mod conflicting as I can't reproduce this in my own modpack. Do you have your mod list?

WenXin20 commented 3 years ago

Here it is, it's not small though: https://gist.github.com/WenXin20/1f40d17f80995d108f8dcd88a823dce4 Maybe Ferritecore, Chunk Saving Fix, or Flywheel?

spoorn commented 3 years ago

It's probably not Ferritecore as I use that myself. Could be one of the other 2, or do you have some resource/texture packs on?

WenXin20 commented 3 years ago

Trying without Chunk Saving Fix now. I have several resourcepacks on, mainly personal packs I made myself, like the MC Connected resource pack.

WenXin20 commented 3 years ago

It wasn't the one. I'll try without Flywheel tomorrow.

mcullifer commented 3 years ago

I have been experiencing this issue as well. I have done a lot of testing with it to see what exactly causes the issue. Here are the following observations I made. Some of the things I list are dead ends but it might help with not wasting time on if they are/aren't causing the issue.

These were the observations I've made trying to figure out what is causing the bug I hope it helps. I also wanted to note all of my drivers are up to date. The server I play on does not have this mod server side, we are playing All The Mods 6 with no changes or extra mods added so it's just me running Sodium Reforged.

WenXin20 commented 3 years ago

I tried removing Flywheel and Random Patches, neither fixed it. But upon creating a new server world, I see no light glitches anywhere, so it appears maybe chunks are not getting properly updated after updating the mod. I'm not sure if it is related to another mod since I cannot find any errors in the logs relating to sodium.

WenXin20 commented 3 years ago

After a couple of server restarts, the new world now has the lighting glitch as well... No teleporting was done.

spoorn commented 3 years ago

I haven't touched the lighting code myself so this is all the original Sodium and Phosphor mods. I saw one issue in the main Sodium repo, but it doesn't look as severe as this. Also, I've been playing on a multiplayer server myself with Sodium on it for a while with no issues, but that's on 2.8.

Could either of you try 2.8 or lower between 2.5 and 2.8 to see which version introduced this bug?

I'm guessing it's either Phosphor issues, or Sodium conflicting with some mod or the forge ecosystem since the same issue hasn't been reported with Fabric Sodium

WenXin20 commented 3 years ago

Yeah, that is what I'll be doing next, starting with v2.8.

mcullifer commented 3 years ago

I haven't touched the lighting code myself so this is all the original Sodium and Phosphor mods. I saw one issue in the main Sodium repo, but it doesn't look as severe as this. Also, I've been playing on a multiplayer server myself with Sodium on it for a while with no issues, but that's on 2.8.

Could either of you try 2.8 or lower between 2.5 and 2.8 to see which version introduced this bug?

I'm guessing it's either Phosphor issues, or Sodium conflicting with some mod or the forge ecosystem since the same issue hasn't been reported with Fabric Sodium

I tested 2.5-2.9.1 the bug starts at version 2.6 and persists through 2.9.1. I am unable to reproduce the bug on 2.5.

WenXin20 commented 3 years ago

It is the same for me, v2.6+ has the same issue.

spoorn commented 3 years ago

Does this also happen when using a Oneshot renderer (disable Multidraw)?

mcullifer commented 3 years ago

Does this also happen when using a Oneshot renderer (disable Multidraw)?

I believe OP's second image says they're using oneshot

exentio commented 3 years ago

I'm having a similar issue, more steps are necessary to reproduce it and the area with the issue is small, reloading the chunks resolves the problem. Basically, I use waystones to travel on a close chunk but on way higher terrain (Tinkers' slime islands), when I come back some chunks are completely dark, both indoors with lamps and lights and outside where there are no light-emitting blocks. If I go away and the chunks stop rendering, then I come back, everything's fixed. The issue is not present in 2.5 (didn't try with anything between 2.6 and 2.9, right now I'm on 2.9.1), doesn't seem to be mod-related. I'm on Linux (Arch/Artix) with the latest xf86-video-amdgpu drivers, RX480 GPU

Shadowex3 commented 3 years ago

It's definitely something to do with teleporting. I can reproduce this reliably using journeymap's waypoint teleports. Bounce back and forth too many times and you'll start producing unlit chunks.

WenXin20 commented 3 years ago

Odd. I don't need to teleport at all for this to happen. It happens as soon as the server loads

spoorn commented 3 years ago

Found out this is due to https://github.com/spoorn/sodium-forge/commit/e331f5f7143419d8307a8036a8b15fffcefb7e71

WenXin20 commented 3 years ago

Awesome, thanks! I'll give the new version a try later.