Compatibility issues with older Python versions

spoqa / sqlalchemy-utc

SQLAlchemy type to store aware datetime values

https://pypi.python.org/pypi/SQLAlchemy-Utc

MIT License

101 stars 20 forks source link

Compatibility issues with older Python versions #13

Open ItachiSan opened 3 years ago

ItachiSan commented 3 years ago

Following my pull request ( #12 ), I noticed that older Python versions fail to work.

I see two options going forward:

Adding back-compatible code for Python 2.7 and drop up to Python 3.5
Dropping all the old versions all together

I am creating this issue so that we can have a discussion about it 😄

dahlia commented 3 years ago

AFAIK @spoqa, the team who maintains this project, still uses few in-house Python 2.7 projects, so the project should be compatible with Python 2.7 yet.

ItachiSan commented 3 years ago

The Travis CI tests however fail in all the situations for Python 2.7 and Pypy...

ItachiSan commented 3 years ago

@dahlia I found the issue: the package itself works, but the dependencies failed. I've been adjusted the dependencies in order to get all to work. 😄 What about the old Python / SQLAlchemy versions?

dahlia commented 3 years ago

It's okay to drop older Python 3 versions.
Python 2.7 should be supported yet.
SQLAlchemy 1.3+ should be supported.

ItachiSan commented 3 years ago

I've decided for not removing stuff from the Travis CI file but to document which versions are supported and not. 😄 Does that work? (see #12)