search

spoqa / sqlalchemy-utc

SQLAlchemy type to store aware datetime values
https://pypi.python.org/pypi/SQLAlchemy-Utc
MIT License
101 stars 20 forks source link

Reindent .travis.yml for improved readability #5

Closed gwax closed 6 years ago

gwax commented 6 years ago

This PR reindents .travis.yml as well as adding additional new lines in order to improve the visual scoping of sections and overall readability.

The diff will be best viewed with whitespace ignored: ?w=1

codecov-io commented 6 years ago

Codecov Report

Merging #5 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master       #5   +/-   ##
=======================================
  Coverage   96.55%   96.55%           
=======================================
  Files           1        1           
  Lines          29       29           
=======================================
  Hits           28       28           
  Misses          1        1

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3d4cf0e...c4316b7. Read the comment docs.

gwax commented 6 years ago

@dahlia this PR is ready for review

dahlia commented 6 years ago

I'm sorry but this is the one I hardly can accept — the overall adjustment seems quite subject and the current style (the way to indent in particular) indeed looks more readable and balanced to me. 🤔 If I can accept only some parts of this these would be added new lines.

gwax commented 6 years ago

Ok, I'm happy to drop this PR and stick with the existing yaml style.