Item count errors

[spannerisms]

Console or Emulator: BizHawk, snes9x core

Seed: http://vt.alttp.run/h/35MzEn1QGE

Description of problem: Throwing bow+silvers into a fairy fountain increments the item count by 1, exactly once.

This gif shows me tossing the bow in twice (once with wooden arrows, once with silvers). The number in the top-left corner is the value of $7EF423, which Myramong said was the address which holds your X/216 item count. Playing through, that appears to be correct.

https://gfycat.com/ThriftyVapidBluebreastedkookaburra

Edit: Unable to reproduce with fat fairy on the same play-through.

[KevinCathcart]

Looking at the cause, there would also be an issue where in customizer if the bow or silver arrows is placed multiple times, only one of them is counted.

There is code in place to count bow+silvers exactly once. In modern randomizer (at least for non-vanilla seeds) we don't want to count the fairy giving the bow+silvers at all. Perhaps counting it only in "vanilla" seeds. But otherwise that upgrade is disabled, since the chests are there to replace it.

This code in question is at: https://github.com/mmxbass/z3randomizer/blob/cecd7635ea463a76e61bfbc9d7c4b973be84f864/inventory.asm#L335

[spannerisms]

An issue must exist elsewhere as well though. A 218/216 seed was reported, but this particular scenario can only produce 217/216.

[Simn]

We tested if this was related to buying shields from a shop, but that didn't increase the counter.

[spannerisms]

Tested (strike means no issue):

• Fairy toss:
  • Boomerangs (all combos/tosses)
  • Swords:
  • Fighter's (oddly safe)
  • Master (increments)
  • Tempered (increments)
  • Butter (increments)
  • Bottles
  • Shields
  • Mails
• Digging game twice
• Chest game twice