sporkmonger / uuidtools

A simple universally unique ID generation library.
http://uuidtools.rubyforge.org/
Apache License 2.0
425 stars 63 forks source link

Check backup path for nil also #54

Open rcalosso opened 2 years ago

rcalosso commented 2 years ago

Cleanly handles missing ifconfig and ip command such as went in a docker image

RoverWire commented 11 months ago

Why this is not merged yet? @sporkmonger

I think this is a great fix for a common issue on containers.

nwallace commented 10 months ago

I'm just commenting here to add that this fixes #53 so that GitHub will cross-link this PR with that issue. @sporkmonger are you still maintaining this? Let us know if you need help

Edit: I hadn't actually tried this PR when I initially left this comment. While the cross-linking is still good to have, this PR didn't fully solve my problem. It fixed the call to UUIDTools::UUID::ifconfig, but calls to UUIDTools::UUID::first_mac (which is used by UUIDTools::UUID::timestamp_create) still failed. #55 fixes both issues