sporkrb / spork-rails

Spork plugin for rails
MIT License
184 stars 45 forks source link

Rails 4 #13

Closed sahilm closed 11 years ago

sahilm commented 11 years ago

Hello Folks,

I ran into a small issue while attempting to use spork-rails with a rails 4 project. I don't really think my pull request contains everything required to support rails 4 but I've tried to make a start.

Do let me know what you guys think.

Thanks.

arthurnn commented 11 years ago

+1 on this feature.

whatthewhat commented 11 years ago

+1 sahilm's fork works for me on current rails 4 master

arthurnn commented 11 years ago

I have those changes running in beta project for a month, and no problems so far.

jasnow commented 11 years ago

I need this too to upgrade to Rails 4.0

threadhead commented 11 years ago

+1, with a pretty please

cykhoo commented 11 years ago

+1 - would be great to have this now Rails 4 beta is out!

mhartl commented 11 years ago

+1. This is currently preventing me from incorporating Spork into the Rails 4 draft of the Ruby on Rails Tutorial.

ekampp commented 11 years ago

:+1:

bwobst commented 11 years ago

+1 and +1 to mhartl for working on a Rails 4 version of the tutorial!

tetherit commented 11 years ago

+1 still no rails 4 support? :(

koriroys commented 11 years ago

My fix: https://github.com/koriroys/spork-rails/commit/355a354e9de328e86a9f3fe306f243745950a7d1

koriroys commented 11 years ago

@bwobst does your gemfile look like this?

gem 'spork-rails', git: 'git://github.com/koriroys/spork-rails.git'

and you are running bundle update spork-rails

Cheers

bwobst commented 11 years ago

@koriroys Gemfile looks like that now! Returns "Couldn't find gem 'spork-rails'". Also, 'git clone' fails when doing 'bundle update' by itself.

jarijokinen commented 11 years ago

Forks by @sahilm or @koriroys are not working anymore with Rails 4.0.0.beta1 (or master), Ruby 2.0.0 p0 and RSpec.

$ bundle exec spork
Using RSpec, Rails
Preloading Rails environment
Loading Spork.prefork block...
undefined method `sub' for nil:NilClass (NoMethodError)

Full stack trace: https://gist.github.com/jarijokinen/5180864

Gemfile is the initial file generated by the "rails new" command, with these additions:

gem "rspec-rails"
gem "spork-rails", github: "koriroys/spork-rails"

The weird thing is that this worked fine earlier, but suddenly stopped working.

Any ideas how to fix this?

kennyj commented 11 years ago

Hi @jarijokinen It seems that this is related to #16 .

josemotanet commented 11 years ago

Any updates on this? I'm currently working on a course for Tuts+ Premium with Spork and would love this to work.

timdorr commented 11 years ago

Now that Rails 4 is out, is anyone going to merge this? It seems the Spork folks are asleep at the wheel :unamused:

kostia commented 11 years ago

+1 Please merge and release ASAP.

kirkonrails commented 11 years ago

+1

nixme commented 11 years ago

Hi guys, not sure if @timcharper has had much time to work on spork lately. I know I haven't on the spork-testunit side.

As a current solution, I suggest people try https://github.com/jonleighton/spring

kathgironpe commented 11 years ago

+1 please merge this. Thank you.

kanfet commented 11 years ago

+1

sahilm commented 11 years ago

I authored this pull request 6 months ago. Clearly the people maintaing spork-rails have moved on to other things. As @nixme has already mentioned, there are new tools to do this kind of stuff like Zeus, Spring and Commands. I would suggest watching episode #412 Fast Rails Commands of the excellent RailsCasts for a rundown on all of these new tools.

Cheers.

timcharper commented 11 years ago

I have not been receiving github notifications, I'm not sure why. Anyways, yes, I've moved on, I haven't worked on a ruby-on-rails project for several years, and consequently, a project that would need a solution as spork.

Happy to hand the reigns over to somebody. But if it would be better, I can just shut it down and refer people to the other tools.

timcharper commented 11 years ago

@sahilm you have github access.

sahilm commented 11 years ago

@timcharper Thanks for granting me GitHub access. I will revise my implementation and make a commit soon. Also, I don't mind taking a stab at maintaing spork.

mat813 commented 11 years ago

@sahilm :+1:

amalc commented 11 years ago

@sahilm :+1:

sahilm commented 11 years ago

Support for Rails 4, Ruby 2.0, Cucumber 1.3.2 and Rspec 2.13.0 has landed on master. Please help me test by including spork-rails, :github => 'sporkrb/spork-rails' in your Gemfile.

CI builds for spork and spork-rails have been setup at https://travis-ci.org/sporkrb/spork and https://travis-ci.org/sporkrb/spork-rails respectively.

I'm going to send out an email to @timcharper requesting RubyGems access.

Thanks.

kanfet commented 11 years ago

Please help me test by including spork-rails, :github => 'sporkrb/spork-rails' in your Gemfile.

It works in my application on Rails 4, Ruby 2.0 and Rspec 2.13.2!

cschiewek commented 11 years ago

Works fine, even with guard-spork.

kanfet commented 11 years ago

I use spork-rails with guard-spork in my application. I tested it one minute ago again. It works with guard-spork 1.5.1

railstutorial commented 11 years ago

Guard appears to work OK on my system with

  gem 'guard-rspec', '2.5.0'
  gem 'spork-rails', github: 'sporkrb/spork-rails'
  gem 'guard-spork', '1.5.0'
ghost commented 11 years ago

I was having a really hard time with this, but I finally got rails 4, spork, rspec, and guard working after I read this:

http://stackoverflow.com/questions/14791957/guard-spork-rspec-issue-how-do-i-remove-hooks-to-testunit

railstutorial commented 11 years ago

I think this should only happen if there's a test directory. Does it happen for you in any case? I can't reproduce the issue on my system.

ghost commented 11 years ago

No, you're right. It happened because I DO have a test directory. Once I deleted it, it worked fine. But since I have other tests in that directory, I didn't want to delete it. So I was able to get it working by supplying the :test_unit=>false option to the Spork block in my Guardfile.

guard 'spork', :test_unit=>false do
  ...
end
kathgironpe commented 11 years ago

@sahilm thank you

sahilm commented 11 years ago

Just released spork-rails 4.0.0 to RubyGems. It's no longer necessary to pull the gem from GitHub.

cykhoo commented 11 years ago

Thank you very much!

On 14 Sep 2013, at 20:34, Sahil Muthoo notifications@github.com wrote:

Just released spork-rails 4.0.0 to RubyGems. It's no longer necessary to pull the gem from GitHub.

— Reply to this email directly or view it on GitHub.

kanfet commented 11 years ago

Thank you!