sporkrb / spork-rails

Spork plugin for rails
MIT License
184 stars 45 forks source link

Deprecation with RSpec 2.99.0 rc1 #25

Open nathany opened 10 years ago

nathany commented 10 years ago

<RSpec::Core::DeprecationError: Instantiating a RSpec::Core::CommandLine with an array of options is deprecated. Use Instantiate a RSpec::Core::Runner with a RSpec::Core::ConfigurationOptions instance instead. Called from ~/.rvm/gems/ruby-2.1.2/gems/spork-1.0.0rc4/lib/spork/test_framework/rspec.rb:11

nathany commented 10 years ago

Note: it's not possible to enable RSpec's config.raise_errors_for_deprecations! option to prevent deprecations in our own code. This becomes an error at the beginning and prevents guard from continuing. /cc @myronmarston

myronmarston commented 10 years ago

Note: it's not possible to enable RSpec's config.raise_errors_for_deprecations! option to prevent deprecations in our own code. This becomes an error at the beginning and prevents guard from continuing. /cc @myronmarston

@nathany -- you could try delaying when you set that config until after this warning has been issued:

RSpec.configure do |config|
  before(:suite) { config.raise_errors_for_deprecations! }
end
nathany commented 10 years ago

Good point. Thanks @myronmarston.

I'm not 100% sure if that works, as I've fixed all our other deprecations. :smile: