search

sporkus / probe_accuracy_tests

GNU General Public License v3.0
139 stars 29 forks source link

Several script issues while using tap #22

Closed ecxs-daedalus closed 11 months ago

ecxs-daedalus commented 1 year ago

I tried to run the script on an Voron 2.4 with Tap and encountered the following issues:

  1. Currently the script is not detecting my Tap configuration. L592:

    if endstop_pin == "probe:z_virtual_endstop":

    should be the following, to deal with additional whitespaces:

    if re.search("probe:\s*z_virtual_endstop", endstop_pin):

  2. There is currently no graceful abort if no probe is detected.

  3. The "--detect_probe" argument should have the argument: action="store_true",

  4. There is always a KeyError: 'x_offset' after leveling L516f:

    x_offset = PRINTER.config["probe"]["x_offset"]
y_offset = PRINTER.config["probe"]["y_offset"]

    this should be the following, to deal with options that are not present on tap:

    x_offset = PRINTER.config["probe"].get("x_offset", 0)
y_offset = PRINTER.config["probe"].get("y_offset", 0)

  5. The measurements should be put into /tmp, like the probe_accuracy scripts from KiloQubit or better with an option flag like "--output_dir"

  6. probe_config does not have the attribute "samples". L370:

    msg = f"\nYour probe config uses {agg_method} of {probe_config['samples']} sample(s) over {n_test} tests"