search

sportngin / brew-gem

Install gems as homebrew formulas
MIT License
195 stars 22 forks source link

Miscellaneous fixes #12

Closed jacknagel closed 10 years ago

jacknagel commented 10 years ago

Hi,

I need to make some changes to the download strategies in Homebrew in order to make implementing some new features possible. The strategy classes have evolved a fairly unconstrained API over the years, so as you can imagine, knowing what is safe to change is difficult.

To that end, I am trying to get a feel for how these classes are being used outside of Homebrew core, and hopefully I am able to point out where things can be done in a different/simpler way.

I will leave some comments in the diff explaining the changes.

Thanks!

anfleene commented 10 years ago

Wow! Thanks! I was pretty fuzzy on how to implement the download strategy properly. This looks way better.

This is really the first formula that we've worked on so having someone point out the correct way to do this stuff is a huge help. I'll pull down these changes and merge them in once I test them out.

Thanks!

anfleene commented 10 years ago

I cut a new release and it's been updated in our tap. Thanks again!