search

sportngin / brew-gem

Install gems as homebrew formulas
MIT License
195 stars 21 forks source link

Brew gem breakup #23

Closed nicksieger closed 8 years ago

nicksieger commented 8 years ago

Addresses issues in #16.

Also, the way the code is written now, it would be straightforward to add sha256 support using the Rubygems API to fetch gem information.

anfleene commented 8 years ago

Holy shit this awesome!! I can do a more thorough review in a bit.

anfleene commented 8 years ago

Great Idea making this a gem. I think it makes it way easier to develop.

I opened #24 to represent setting the sha in the download strategy great idea.

nicksieger commented 8 years ago

Yeah, I wasn't sure if we actually want to release and distribute as a gem, but it might make sense to do so?

anfleene commented 8 years ago

we could. It for sure makes development of it way easier. Assuming it works the same as a gem as it does for homebrew I think it's fine. I wonder what would happen if you brew-gem brew-gem.

nicksieger commented 8 years ago

Ok, I'm ready to merge. Let me know and I can cut the release and push to rubygems. I also have updates to the Homebrew/homebrew-core recipe in flight.

anfleene commented 8 years ago

:shipit: Nice work!