search

sportngin / brew-gem

Install gems as homebrew formulas
MIT License
198 stars 22 forks source link

FIX of installation of brew-gems, RubyGems=>3.0.2 #57

Closed JuPlutonic closed 5 years ago

JuPlutonic commented 5 years ago

IF RubyGems=>3.0.2 only supported parameter is --no-document Where are some discussions here https://github.com/jordansissel/fpm/pull/1583 and here https://github.com/jordansissel/fpm/issues/1582 (If RubyGems < 2 this PR breaks installation)

JuPlutonic commented 5 years ago

@sportngin please provide review and Merge/Close. Thank you.

nicksieger commented 5 years ago

Could you make this compatible with both RubyGems 2.x and RubyGems 3 please?

jasonkarns commented 5 years ago

@nicksieger --no-document was introduced by RubyGems 2.x. Indeed, the ri/rdoc options were deprecated by 2.x and only just now completely dropped by 3.x

https://blog.rubygems.org/2013/02/24/2.0.0-released.html

JuPlutonic commented 5 years ago

Yes, I see what the change is only drops RubyGems 1.x support

nicksieger commented 5 years ago

Ah, great, thanks for the clarification. And thanks for the contribution!