search

sportradar / UnifiedOddsSdkNetCore

UnifiedFeed SDK is a client library that enables easier integration with the Betradar XML feeds. SDK exposes XML feed service interface in a more user-friendly way and isolates the client from having to do XML feed parsing, proper connection handling, error recovery, event queuing, data caching and dispatching.
https://sportradar.github.io/UnifiedOddsSdkNetCore/
Other
17 stars 14 forks source link

Useless need of lock around MemoryCache that is thread safe #5

Closed micdenny closed 2 years ago

micdenny commented 4 years ago

The lock around System.Runtime.Caching.MemoryCache is not needed because MemoryCache is thread safe.

https://github.com/sportradar/UnifiedOddsSdkNetCore/blob/43f34aa4b901f64395c1af00d09465f687556806/src/Sportradar.OddsFeed.SDK/Entities/REST/Internal/Caching/SportEventStatusCache.cs#L116-L125

I didn't check all the source code, but I've found it in SportEventStatusCache and I wanted to point it out.

dhrovat commented 2 years ago

Thank you for pointing that out. Lock was cleaned up. Will be available in next release.