sports-alliance / sports-lib

A Library for processing GPX, TCX, FIT and JSON files from services such as Strava, Movescount, Garmin, Polar etc
GNU Affero General Public License v3.0
156 stars 21 forks source link

GXParser DOMParser issues #21

Closed isabolic closed 5 years ago

isabolic commented 5 years ago

The problem is in GXParser depend. which DOMParser is not included

(node:2030) UnhandledPromiseRejectionWarning: ReferenceError: DOMParser is not defined at GXParser (/mnt/c/greyp.workspace/playground/g6simulator/node_modules/gxparser/GXParser.js:40:16) at /mnt/c/greyp.workspace/playground/g6simulator/node_modules/quantified-self-lib/lib/events/adapters/importers/gpx/importer.gpx.js:34:29

jimmykane commented 5 years ago

Hey hi @isabolic , Indeed I think GPX parser was not made for Node (if I understand from the logs).

I ll check this and create fix for this.

However, I am in the middle of a big refactoring (will be using streams instead of points due to big data) and wanted to ask you how much will it cost if I have this fixed by the end of the year.....

isabolic commented 5 years ago

@jimmykane Hi,

no pressure, I have found a workaround.

Best regards isabolic

jimmykane commented 5 years ago

v2.2.4 fixes this