Closed thomaschampagne closed 4 years ago
Hey lets target develop as there should be all work "done" typically. Develop should now be up to date.
And hey thanks for this and the other PR. Will be spending time this week here for both.
For this PR it's ok to target master, I ll handle the updates and fix the tests, update develop, merge master etc.
On it
:exclamation: No coverage uploaded for pull request base (
master@e66389f
). Click here to learn what that means. The diff coverage is69.07%
.
@@ Coverage Diff @@
## master #35 +/- ##
=========================================
Coverage ? 63.73%
=========================================
Files ? 176
Lines ? 4305
Branches ? 665
=========================================
Hits ? 2744
Misses ? 1515
Partials ? 46
Impacted Files | Coverage Δ | |
---|---|---|
src/events/utilities/event.utilities.ts | 63.63% <ø> (ø) |
|
src/data/data.power-zone-two-duration.ts | 100% <100%> (ø) |
|
src/data/data.power-zone-one-duration.ts | 100% <100%> (ø) |
|
src/data/data.speed-zone-four-duration.ts | 100% <100%> (ø) |
|
src/data/data.heart-rate-zone-three-duration.ts | 100% <100%> (ø) |
|
src/data/data.heart-rate-zone-four-duration.ts | 100% <100%> (ø) |
|
src/data/data.power-zone-three-duration.ts | 100% <100%> (ø) |
|
src/data/data.power-zone-five-duration.ts | 100% <100%> (ø) |
|
src/data/data.speed-zone-one-duration.ts | 100% <100%> (ø) |
|
src/data/data.speed-zone-two-duration.ts | 100% <100%> (ø) |
|
... and 9 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update e66389f...a10af87. Read the comment docs.
Updated the PR with latest master which fixes the failing tests due to silly mistake.
Hi @jimmykane,
Here a pull request to fix bug #27. This pull request includes:
Feel free to tell me what can be improved/changed
Note: Tests do not pass because = 2 legacy jest tests are failing.
Are you using Gitflow? Seen a
develop
branch... Tell me if you want PR on develop instead.Hope this helps.