@types/node should be a devDependcy only?

sports-alliance / sports-lib

A Library for processing GPX, TCX, FIT and JSON files from services such as Strava, Movescount, Garmin, Polar etc

GNU Affero General Public License v3.0

155 stars 21 forks source link

Closed tbsmark86 closed 4 years ago

tbsmark86 commented 4 years ago

Hi, just tryed your code and this seemed strange after installing via npm.

Also it should be "npm install @sports-alliance/sports-lib" in the readme

jimmykane commented 4 years ago

Hey hi @tbsmark86 thanks for reporting this.

The readme file should be updated asap.

regarding the save vs save-dev I think this explains it:

However, if you think otherwise and there is something I am missing out, that is very likely, I would be happy to learn :-D

jimmykane commented 4 years ago

Sorry for the close, that was done automatic as I tagged and pushed one commit

tbsmark86 commented 4 years ago

No I don't known anything else - just felt strange to me as an typescript newbie.

Edit: Well - technically the publised npm package does not contain any typescript :) But as i sad I'am a newbie.