sports-alliance / sports-lib

A Library for processing GPX, TCX, FIT and JSON files from services such as Strava, Movescount, Garmin, Polar etc
GNU Affero General Public License v3.0
149 stars 21 forks source link

Technical: improved shared code base #82

Closed thomaschampagne closed 3 years ago

thomaschampagne commented 3 years ago

Hey @jimmykane,

This pull-request add the following:

There is no changes in the code behavior

Greetings,

Thomas

codecov-commenter commented 3 years ago

Codecov Report

Merging #82 (25c61b6) into develop (e9069d9) will decrease coverage by 2.07%. The diff coverage is 66.79%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #82      +/-   ##
===========================================
- Coverage    79.17%   77.10%   -2.08%     
===========================================
  Files          196      196              
  Lines         5264     5696     +432     
  Branches       841     1094     +253     
===========================================
+ Hits          4168     4392     +224     
- Misses        1071     1291     +220     
+ Partials        25       13      -12     
Impacted Files Coverage Δ
src/activities/devices/device.ts 28.57% <0.00%> (+3.57%) :arrow_up:
src/creators/creator.ts 73.68% <0.00%> (+14.86%) :arrow_up:
src/data/data.battery-charge.ts 85.71% <0.00%> (ø)
src/data/data.battery-current.ts 85.71% <0.00%> (ø)
src/data/data.battery-voltage.ts 85.71% <0.00%> (ø)
src/data/data.distance.ts 84.61% <ø> (ø)
src/data/data.duration.ts 24.13% <0.00%> (-1.95%) :arrow_down:
src/data/data.grade-adjusted-speed-avg.ts 85.00% <ø> (ø)
src/data/data.grade-adjusted-speed.ts 67.64% <ø> (-7.36%) :arrow_down:
src/data/data.interface.ts 100.00% <ø> (ø)
... and 91 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e9069d9...25c61b6. Read the comment docs.

jimmykane commented 3 years ago

Will check this asap 🙏

On Sat, 5 Jun 2021, 15:59 Thomas Champagne, @.***> wrote:

@thomaschampagne https://github.com/thomaschampagne requested your review on: #82 https://github.com/sports-alliance/sports-lib/pull/82 Technical: improved shared code base.

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/sports-alliance/sports-lib/pull/82#event-4846732883, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJVX4ZWFEN7AQQPL554U4LTRIUUPANCNFSM4447OVQQ .