sports-club-hanzan / virtual-pilgrimage

仮想的に四国八十八ヶ所お遍路を体験することができる歩数系アプリ
3 stars 0 forks source link

サインイン・ユーザ登録ページの改善 #46

Closed rikeda71 closed 2 years ago

rikeda71 commented 2 years ago

@itomizu サインインページ・ユーザ登録ページのデザインおよびロジックの改善を実施しました。

imageimage imageimage

codecov[bot] commented 2 years ago

Codecov Report

Base: 43.50% // Head: 43.03% // Decreases project coverage by -0.47% :warning:

Coverage data is based on head (6274919) compared to base (f87810f). Patch coverage: 13.57% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #46 +/- ## ========================================== - Coverage 43.50% 43.03% -0.48% ========================================== Files 79 81 +2 Lines 1517 1594 +77 ========================================== + Hits 660 686 +26 - Misses 857 908 +51 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `43.03% <13.57%> (-0.48%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ryuya+Ikeda#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/s14t284/virtual-pilgrimage/pull/46?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ryuya+Ikeda) | Coverage Δ | | |---|---|---| | [lib/domain/auth/sign\_in\_usecase.dart](https://codecov.io/gh/s14t284/virtual-pilgrimage/pull/46/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ryuya+Ikeda#diff-bGliL2RvbWFpbi9hdXRoL3NpZ25faW5fdXNlY2FzZS5kYXJ0) | `100.00% <ø> (ø)` | | | [lib/domain/exception/sign\_in\_exception.dart](https://codecov.io/gh/s14t284/virtual-pilgrimage/pull/46/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ryuya+Ikeda#diff-bGliL2RvbWFpbi9leGNlcHRpb24vc2lnbl9pbl9leGNlcHRpb24uZGFydA==) | `50.00% <ø> (ø)` | | | [...omain/user/pilgrimage/pilgrimage\_info.codegen.dart](https://codecov.io/gh/s14t284/virtual-pilgrimage/pull/46/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ryuya+Ikeda#diff-bGliL2RvbWFpbi91c2VyL3BpbGdyaW1hZ2UvcGlsZ3JpbWFnZV9pbmZvLmNvZGVnZW4uZGFydA==) | `50.00% <ø> (ø)` | | | [lib/model/form\_model.codegen.dart](https://codecov.io/gh/s14t284/virtual-pilgrimage/pull/46/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ryuya+Ikeda#diff-bGliL21vZGVsL2Zvcm1fbW9kZWwuY29kZWdlbi5kYXJ0) | `81.81% <0.00%> (-10.49%)` | :arrow_down: | | [lib/ui/components/atoms/primary\_button.dart](https://codecov.io/gh/s14t284/virtual-pilgrimage/pull/46/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ryuya+Ikeda#diff-bGliL3VpL2NvbXBvbmVudHMvYXRvbXMvcHJpbWFyeV9idXR0b24uZGFydA==) | `0.00% <0.00%> (ø)` | | | [lib/ui/components/atoms/secondary\_button.dart](https://codecov.io/gh/s14t284/virtual-pilgrimage/pull/46/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ryuya+Ikeda#diff-bGliL3VpL2NvbXBvbmVudHMvYXRvbXMvc2Vjb25kYXJ5X2J1dHRvbi5kYXJ0) | `0.00% <0.00%> (ø)` | | | [lib/ui/components/gender\_radio\_buttons.dart](https://codecov.io/gh/s14t284/virtual-pilgrimage/pull/46/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ryuya+Ikeda#diff-bGliL3VpL2NvbXBvbmVudHMvZ2VuZGVyX3JhZGlvX2J1dHRvbnMuZGFydA==) | `0.00% <0.00%> (ø)` | | | [.../pages/profile/components/profile\_health\_card.dart](https://codecov.io/gh/s14t284/virtual-pilgrimage/pull/46/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ryuya+Ikeda#diff-bGliL3VpL3BhZ2VzL3Byb2ZpbGUvY29tcG9uZW50cy9wcm9maWxlX2hlYWx0aF9jYXJkLmRhcnQ=) | `0.00% <ø> (ø)` | | | [lib/ui/pages/profile/profile\_page.dart](https://codecov.io/gh/s14t284/virtual-pilgrimage/pull/46/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ryuya+Ikeda#diff-bGliL3VpL3BhZ2VzL3Byb2ZpbGUvcHJvZmlsZV9wYWdlLmRhcnQ=) | `0.00% <ø> (ø)` | | | [lib/ui/pages/registration/registration\_page.dart](https://codecov.io/gh/s14t284/virtual-pilgrimage/pull/46/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ryuya+Ikeda#diff-bGliL3VpL3BhZ2VzL3JlZ2lzdHJhdGlvbi9yZWdpc3RyYXRpb25fcGFnZS5kYXJ0) | `1.49% <0.00%> (-0.47%)` | :arrow_down: | | ... and [11 more](https://codecov.io/gh/s14t284/virtual-pilgrimage/pull/46/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ryuya+Ikeda) | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ryuya+Ikeda). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ryuya+Ikeda)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

rikeda71 commented 2 years ago

ありがとうございます!マージします!