sports-club-hanzan / virtual-pilgrimage

仮想的に四国八十八ヶ所お遍路を体験することができる歩数系アプリ
3 stars 0 forks source link

過去の移動経路を描画するよう修正 #98

Closed rikeda71 closed 1 year ago

rikeda71 commented 1 year ago

表題の通りです。 要望があったため対応しました。

愚直に実装すると Firebase への問い合わせ回数が多くなったり、マップへの描画が遅くなって UX を損なうので、以下のように対応しました。

rikeda71 commented 1 year ago

過去経路は淡い桃色 * 少し細い線で可視化しています。 マップが青 or 緑 or 黄色で表現されているので、ピンや経路は赤よりの色が良いと考えています。

image
codecov[bot] commented 1 year ago

Codecov Report

Base: 53.93% // Head: 53.75% // Decreases project coverage by -0.18% :warning:

Coverage data is based on head (042fff1) compared to base (fe53fc5). Patch coverage: 31.25% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #98 +/- ## ========================================== - Coverage 53.93% 53.75% -0.18% ========================================== Files 117 117 Lines 2186 2195 +9 ========================================== + Hits 1179 1180 +1 - Misses 1007 1015 +8 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `53.75% <31.25%> (-0.18%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ryuya+Ikeda#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/s14t284/virtual-pilgrimage/pull/98?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ryuya+Ikeda) | Coverage Δ | | |---|---|---| | [...grimage/update\_pilgrimage\_progress\_interactor.dart](https://codecov.io/gh/s14t284/virtual-pilgrimage/pull/98?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ryuya+Ikeda#diff-bGliL2FwcGxpY2F0aW9uL3BpbGdyaW1hZ2UvdXBkYXRlX3BpbGdyaW1hZ2VfcHJvZ3Jlc3NfaW50ZXJhY3Rvci5kYXJ0) | `90.90% <ø> (ø)` | | | [lib/ui/pages/home/home\_presenter.dart](https://codecov.io/gh/s14t284/virtual-pilgrimage/pull/98?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ryuya+Ikeda#diff-bGliL3VpL3BhZ2VzL2hvbWUvaG9tZV9wcmVzZW50ZXIuZGFydA==) | `23.07% <15.38%> (-1.57%)` | :arrow_down: | | [...rastructure/pilgrimage/temple\_repository\_impl.dart](https://codecov.io/gh/s14t284/virtual-pilgrimage/pull/98?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ryuya+Ikeda#diff-bGliL2luZnJhc3RydWN0dXJlL3BpbGdyaW1hZ2UvdGVtcGxlX3JlcG9zaXRvcnlfaW1wbC5kYXJ0) | `59.52% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ryuya+Ikeda). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ryuya+Ikeda)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.