search

sportsdataverse / cfbfastR

An R package to quickly obtain clean and tidy college football play by play data
https://cfbfastR.sportsdataverse.org
Other
79 stars 8 forks source link

`espn_ratings_fpi` not in CRAN install #51

Closed math-mcshane closed 3 years ago

math-mcshane commented 3 years ago

Describe the bug espn_ratings_fpi not in CRAN install

To Reproduce

install.packages("cfbfastR")
library(cfbfastR)
cfbfastR::espn_ratings_fpi(year = 2018)

Expected behavior For this function to be available https://saiemgilani.github.io/cfbfastR/reference/espn_ratings.html

Screenshots If applicable, add screenshots to help explain your problem. image

Desktop (please complete the following information):

R version 4.1.1 (2021-08-10)
Platform: x86_64-w64-mingw32/x64 (64-bit)
Running under: Windows 10 x64 (build 19041)

other attached packages:
[1] cfbfastR_1.6.4
saiemgilani commented 3 years ago

Curious. I bet I had a reason. The function needed to be rewritten with a better endpoint, I bet. Will review in the coming days and fix upon next release

math-mcshane commented 3 years ago

It looks like it failed one of the checks (MacOS) https://github.com/saiemgilani/cfbfastR/blob/master/R/espn_ratings_fpi.R