sportsdataverse / cfbfastR

An R package to quickly obtain clean and tidy college football play by play data
https://cfbfastR.sportsdataverse.org
Other
74 stars 8 forks source link

EPA on Punt plays looks broken #65

Closed rebinion closed 2 years ago

rebinion commented 2 years ago

Describe the bug The EPA on punt plays does not seem to be factoring correctly.

To Reproduce

  1. Go to the play by play data
  2. Filter play_type == "Punt"
  3. Observe how many punt plays include very large EPA numbers for the defensive team on uneventful plays

Expected behavior For punt plays that net out to around 40 yards, the EPA should be minimal.

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

Smartphone (please complete the following information):

Additional context Add any other context about the problem here.

Kazink36 commented 2 years ago

This should be working properly as of cfbfastR 1.9.0

Feel free to reopen if you still see any funky results.