search

sportsdataverse / cfbfastR

An R package to quickly obtain clean and tidy college football play by play data
https://cfbfastR.sportsdataverse.org
Other
74 stars 8 forks source link

cfbd_betting_lines #93

Closed ryanmamitchell closed 7 months ago

ryanmamitchell commented 10 months ago

In cfbfastR_1.9.0 it only loads certain years of betting data, for example, 2019-2022 but not 2023. However when cross-referenced with the cfbdata website, the betting data can be found there. I also attempted running the code while directly referencing the package (cfbfastR::), as per a previous closed bug report, but to no avail.

To Reproduce

  1. bet_data <- cfbd_betting_lines(year = 2023)
  2. also attempted: bet_i <- cfbfastR::cfbd_betting_lines(year = i)
  3. Error: 2023-11-07 20:13:31: Invalid arguments or no betting lines data available!

Expected behavior Should return my dataset named bet_data containing the betting lines data frame

Desktop (please complete the following information):

Tickkid commented 10 months ago

In cfbfastR_1.9.0 it only loads certain years of betting data, for example, 2019-2022 but not 2023. However when cross-referenced with the cfbdata website, the betting data can be found there. I also attempted running the code while directly referencing the package (cfbfastR::), as per a previous closed bug report, but to no avail.

To Reproduce

  1. bet_data <- cfbd_betting_lines(year = 2023)
  2. also attempted: bet_i <- cfbfastR::cfbd_betting_lines(year = i)
  3. Error: 2023-11-07 20:13:31: Invalid arguments or no betting lines data available!

Expected behavior Should return my dataset named bet_data containing the betting lines data frame

Desktop (please complete the following information):

  • OS: iOS
  • Browser: Chrome

Having same issue on OS: Windows using RStudio 2023.09.1 Build 494 and R version 4.3.2

garbage-time commented 9 months ago

Also having this issue. Currently using R version 4.3.1 and RStudio 524

akeaswaran commented 9 months ago

Hi all:

Looks like CFBData returns a NaN for a FCS betting line in 2023 and cfbfastR doesn't parse that properly. We've let CFBData's maintainers know about that data issue and are working on a fix in cfbfastR to handle edge cases like this better in the future.

Thanks for flagging this!

garbage-time commented 9 months ago

Hi all:

Looks like CFBData returns a NaN for a FCS betting line in 2023 and cfbfastR doesn't parse that properly. We've let CFBData's maintainers know about that data issue and are working on a fix in cfbfastR to handle edge cases like this better in the future.

Thanks for flagging this!

Awesome, thank you!