sportsdataverse / hoopR

An R package to quickly obtain clean and tidy men's basketball play by play data.
http://hoopr.sportsdataverse.org/
Other
81 stars 17 forks source link

Coordinate adjustments #106

Closed rossdrucker closed 1 year ago

rossdrucker commented 1 year ago

Noticed while debugging this issue that the ESPN coordinates that come from the API don't align with how the shot chart displays on the ESPN page. This PR transforms the coordinate system to the following:

Let me know what (if anything) needs to be adjusted here

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
hoopr ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 24, 2023 at 3:37AM (UTC)
rossdrucker commented 1 year ago

FWIW the only tests that are failing locally are the Kenpom functions

saiemgilani commented 1 year ago

Made some updates to comply with tidyselect updates for the dplyr::rename portion of your coordinate alignment