search

sportsdataverse / hoopR

An R package to quickly obtain clean and tidy men's basketball play by play data.
http://hoopr.sportsdataverse.org/
Other
81 stars 18 forks source link

Moved functions that have 2001 data to accepting 2001 as a valid year #114

Closed andreweatherman closed 1 year ago

andreweatherman commented 1 year ago

KenPom recently published 2001 data to select endpoints on his site. On functions servicing that data, I have allowed 2001 to be an accepted year: 

if (!(is.numeric(min_year) && nchar(min_year) == 4 && 
            min_year >= **2001**)) {
            cli::cli_abort("Enter valid min_ as a number (YYYY), data only goes back to **2001**")
        }
vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hoopr ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 28, 2023 5:56am
saiemgilani commented 1 year ago

Andrew, you're a member of the sportsdataverse... why did you fork and PR, but okay, this presumably works. I'll review/make any edits and merge