search

sportsdataverse / hoopR

An R package to quickly obtain clean and tidy men's basketball play by play data.
http://hoopr.sportsdataverse.org/
Other
81 stars 17 forks source link

nba_scoreboard not updating in real-time #129

Open mholbert opened 8 months ago

mholbert commented 8 months ago

nba_scoreboard is not pulling fresh information. It is running about a quarter behind. Is this the best function to use to pull the complete current scoreboard?

To add some additional information. (I've reviewed the code and it makes no sense, but here it is)

nba_scoreboard is returning older information than fromJson from the straight api. It's off by maybe 5-10 minutes. In addition, it will sometimes pull information that was older than its last pull, meaning it will show a game at halftime and then go back to a game in the 2nd period with 5 minutes to go. I know this makes no sense, but I reviewed the return from the function multiple times and days compared to the straight api call. I'm just going to use the straight fromJson call (or write my own wrapper to add header information), so you can close this if you want.

saiemgilani commented 7 months ago

This... is interesting to hear, thank you for the comment. I fully believe you. On the python side we actually have some cache-busting we do generally that we may need to implement elsewhere