search

sportsdataverse / hoopR

An R package to quickly obtain clean and tidy men's basketball play by play data.
http://hoopr.sportsdataverse.org/
Other
81 stars 17 forks source link

hoopR::load_mbb_schedule(2024:2024) resturning zero records #131

Closed Coop197823 closed 7 months ago

Coop197823 commented 8 months ago

I assume this is similar to the issue I reported a few weeks back with the NBA, but the latest 2023/2024 season is coming up with zero records when I run:

hoopR::load_mbb_schedule(2024:2024)

It does return all the records if I run the 2023 season.

I did update the package again. Again, I appreciate your efforts here!

Coop197823 commented 7 months ago

Just following up here to see if a solution will be presented?

aggieed97 commented 7 months ago

Having the same issue (hoopR 2.0.1 in use).

Assuming that the file for the MBB Schedules is from the following link:

https://github.com/sportsdataverse/sportsdataverse-data/releases/tag/espn_mens_college_basketball_schedules

Which shows that 2024 data has not been uploaded yet.

Coop197823 commented 7 months ago

Any Update on this? I still do not see the mbb_schedule_2024.rds at the above link

aqsmith08 commented 7 months ago

Will this bug resolve the same error when I run something like

foo <- hoopR::load_mbb_player_box(seasons = 2024)

Or do I need to submit a standalone issue for that? Thanks and very much appreciate your work on this package! :pray:

Coop197823 commented 7 months ago

It should, but the developer seems to not want to keep this project going.

aggieed97 commented 7 months ago

Normally I would say that someone should submit a Pull Request that fixes the issue, but these particular functions are just looking for RDS files that are not currently being populated for 2023-2024. In the past, they would update every early morning (for the US) throughout the season. I assume those RDS files would be populated by a scrape that either I don't see in this repo or just completely missed. But then again, that daily scrape may just have to be reactivated like they were for the NBA data a few weeks ago.

Coop197823 commented 7 months ago

yes, the same issue happened with the NBA data at the beginning of this season. The developer had been busy with his day job and hopped on and had the webscrape fixed within a day or two of the season start. It seems it he taken him a bit longer to get to for College Bball.

aqsmith08 commented 7 months ago

It'd be great if the developer could fix the scraping / data issue in the short-term, but it'd be nice if we could figure out how this package may be maintained with the help of others. "It takes a village blah blah blah" :)

saiemgilani commented 7 months ago

I agree and all that, your summarization of the situation is accurate, I'd say. The start of the NBA season has had me busier than usual. While I apologize for the delay and general lack of transparency due to the lack of communication, I will get on it for both MBB/WBB and pushing updates to CRAN

aqsmith08 commented 7 months ago

hoopR::load_mbb_schedule(2024) and hoopR::load_mbb_player_box(seasons = 2024) loads the appropriate data now. I think that this issue may be marked as fixed. Thanks so much for your work on this!

Coop197823 commented 7 months ago

Everything is working as intended, you can consider this closed. I would also be interested in helping with getting the API up and running for the NBA and NCAA basketball seasons next year if you need a helping hand.