Remove dependency on usethis and progressr

olivroy commented 7 months ago

Use cli for messages. https://cli.r-lib.org/articles/usethis-ui.html

I also made some cleanups here and there.

I also removed progressr dependency in favour of cli which has support for progress bars.

I made use of rlang::check_installed() when necessary.

I removed unused Suggests.

Since where() is now exported by dplyr, I namespaced it instead of adding it to globalvariables.

Cheers

Summary by CodeRabbit

New Features
- Added new functions hoop_todo and hoop_info for enhanced message display with timestamps.
Enhancements
- Simplified user authentication functions for better reliability.
- Enhanced csv_from_url function description to clarify its role as a wrapper around data.table::fread().
Documentation
- Updated URLs in documentation to use HTTPS for improved security.
- Simplified code snippets in README and vignettes by removing progressr::with_progress wrapper.
Bug Fixes
- Fixed spacing in the login function for consistency.
Refactor
- Removed unused dependencies such as progressr, usethis, and others to streamline package requirements.
Tests
- Modified test assertions for improved clarity and reliability in data frame column name checks.

vercel[bot] commented 7 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
hoopr	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 7, 2024 11:23pm

sweep-ai[bot] commented 7 months ago

Apply Sweep Rules to your PR?

[ ] Apply: All new business logic should have corresponding unit tests.
[ ] Apply: Refactor large functions to be more modular.
[ ] Apply: Add docstrings to all functions and file headers.

saiemgilani commented 7 months ago

You a real one for this.

For the record, I wrap the function names in the documents with the triple backticks so that {pkgdown} will definitely auto-link the functions appropriately. I don't just think that's an appropriate generally, it's more of a means to an end. If something has changed with how that works, lmk. If not, I'd appreciate a quick reversal on that piece of editing

olivroy commented 7 months ago

It works with single back ticks now :) See https://dplyr.tidyverse.org/news and https://github.com/tidyverse/dplyr/blob/main/NEWS.md?plain=1

saiemgilani commented 7 months ago

It works with single back ticks now :) See https://dplyr.tidyverse.org/news and https://github.com/tidyverse/dplyr/blob/main/NEWS.md?plain=1

Oh bet, good tip, I suppose I will merge it when I get a chance to review tonight or so. Appreciate your help!

coderabbitai[bot] commented 2 months ago

Walkthrough

The recent changes to the hoopR package focus on enhancing security, efficiency, and usability. Updates include transitioning to HTTPS for URLs, refining dependencies by removing outdated packages, and simplifying function calls. Notable improvements involve eliminating progressr for progress tracking, updating function parameters, and streamlining data loading processes in the package.

Changes

File Path	Change Summary
`R/utils.R`	Simplified function definitions, improved error handling, and updated progress tracking methods.
`DESCRIPTION`, `README.*`	Updated URLs to HTTPS, revised package dependencies, and simplified code snippets.
`man/*.Rd`, `vignettes/...`	Documentation adjustments reflecting changes in progress bar usage and parameter updates.
`data-raw/pull_team_links.R`	Removed the `progressr` library import, impacting script dependencies.
`tests/testthat/test-kp_arenas.R`	Changed assertion method for checking column names in a data frame.

🐰✨📜 In the realm of data where the rabbits roam, hoopR evolves, enhancing its home. Secure URLs, simplified ways, Progress bars gone, brighter days. Hop, hop, hooray, let the data play! 🌟🎉 🐰✨📜

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

sportsdataverse / hoopR