sportsdataverse / sportsdataverse-py

sportsdataverse python package
https://py.sportsdataverse.org
MIT License
74 stars 7 forks source link

Example sdv.cfb.cfb_teams() call results in error #29

Closed KeeonTabrizi closed 2 years ago

KeeonTabrizi commented 2 years ago

https://py.sportsdataverse.org/docs/cfb/

Example:


import sportsdataverse as sdv
cfb_df = sportsdataverse.cfb.cfb_teams()

>> 
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
Input In [12], in <cell line: 1>()
----> 1 sdv.cfb.cfb_teams()

TypeError: 'module' object is not callable
armstjc commented 2 years ago

So, one of 2 issues are at hand.

  1. cfbFastR-data has it's main branch called 'main', and not 'master' as it's defined in sportsdataverse/config.py
  2. The name of the function needs to be renamed to something like 'get_cfb_teams()', instead of 'cfb_teams()' image

image

A branch has been created with a potential fix to this bug.