search

sportsdataverse / sportsdataverse-py

sportsdataverse python package
https://py.sportsdataverse.org
MIT License
78 stars 8 forks source link

Armstjc/fix mlb function names - Release Candidate 2 #37

Closed armstjc closed 2 years ago

vercel[bot] commented 2 years ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
sportsdataverse-py ✅ Ready (Inspect) Visit Preview Aug 5, 2022 at 4:00PM (UTC)
saiemgilani commented 2 years ago

why do these have loads_? shouldn't it be like mlbam_transactions() ?

armstjc commented 2 years ago

why do these have loads_? shouldn't it be like mlbam_transactions() ?

Because the function/API call requires a range of dates for the call to work, and there isn't another function like this in sdv-py.

saiemgilani commented 2 years ago

why do these have loads_? shouldn't it be like mlbam_transactions() ?

Because the function/API call requires a range of dates for the call to work, and there isn't another function like this in sdv-py.

Fine but I reserve the right to change the naming convention here if I feel like it is necessary