search

sportsdataverse / wehoop

An R package to quickly obtain clean and tidy women's basketball play by play data.
https://wehoop.sportsdataverse.org/
Other
17 stars 2 forks source link

Directly use column name in `unnest_wider()` calls #14

Closed DavisVaughan closed 2 years ago

DavisVaughan commented 2 years ago

Hi, I am working on improving the rectangling functions in tidyr, and your package came up in revdep checks, see https://github.com/tidyverse/tidyr/pull/1200.

In particular, there are many usages of unlist(.data$col) where really you just needed to use .data$col. It is unfortunate that the previous behavior worked at all, but it is considered off-label and we don't support it.

This PR fixes those issues. It does not require dev tidyr, so this one could be merged and sent to CRAN without needing the new version of tidyr.

vercel[bot] commented 2 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/saiemgilani/wehoop/D8T4Z6SLoTEYk4Uy2L2N3nNyh4NK
✅ Preview: https://wehoop-git-fork-davisvaughan-fix-unnest-wider-usage-saiemgilani.vercel.app

saiemgilani commented 2 years ago

You're a real hero in the field. Much obliged.