search

sportsdataverse / wehoop

An R package to quickly obtain clean and tidy women's basketball play by play data.
https://wehoop.sportsdataverse.org/
Other
17 stars 2 forks source link

text_type in load_wbb_pbp has MadeFreeThrow for both made and missed free throws #18

Open sambruchhaus opened 2 years ago

sambruchhaus commented 2 years ago

Describe the bug The column _texttype in the resulting data from load_wbb_pbp() has "MadeFreeThrow" for both made and missed free throws

To Reproduce Steps to reproduce the behavior:

  1. Call load_wbb_pbp()
  2. Filter by text to retrieve missed free throws
  3. text for "[Name] missed Free Throw" has "MadeFreeThrow" for the value of _texttype

Expected behavior The text should be either "FreeThrow" or "MissedFreeThrow" for more intuitive filtering.

Screenshots If applicable, add screenshots to help explain your problem.

Screen Shot 2022-01-11 at 6 34 16 PM

Version: 1.2.1

Additional context Encountered while trying to calculate Athletes Unlimited Scoring from Play-by-Play

saiemgilani commented 2 years ago

While not something I mess with to create the type_text field, nonetheless disconcerting. I will try to validate more as the season goes along (more like off-season) , but if you have like code to validate the types, I'd welcome a PR