Closed jmhyman-su closed 10 months ago
Any luck getting 2023 data?
I haven’t tested again. Was waiting for the bug ticket to be updated.
-Aaron From: iksnizez @.> Sent: Wednesday, August 9, 2023 10:13 PM To: sportsdataverse/wehoop @.> Cc: Aaron Morris @.>; Manual @.> Subject: Re: [sportsdataverse/wehoop] WNBA pbp error for 2023 (Issue #31)
Any luck getting 2023 data?
— Reply to this email directly, view it on GitHubhttps://github.com/sportsdataverse/wehoop/issues/31#issuecomment-1672435246, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A24L24FNMF3AKCVGXBA4SMLXUQ7RTANCNFSM6AAAAAAYNX2DVI. You are receiving this because you are subscribed to this thread.Message ID: @.**@.>>
All load_wnba_x
functions should work now
cc: @jmhyman-su, @iksnizez, @aaronmorrisNC
Wait this issue wasn't related to the releases not getting updated, these folks needed to move to the development version of the package. The data was being updated.
Run:
remotes::install_github("sportsdataverse/wehoop")
Refresh your session.
We need to reverse #34
closed by 29c4ea7e3baaf91235336753238abf597a6fe749
Describe the bug The load_wnba_pbp function does not appear to work yet for the 2023 season
To Reproduce wehoop::load_wnba_pbp(seasons = 2023) returns:
Warning messages: 1: In readRDS(con) : cannot open URL 'https://raw.githubusercontent.com/sportsdataverse/wehoop-data/main/wnba/pbp/rds/play_by_play_2023.rds': HTTP status was '404 Not Found'
Expected behavior Older seasons still work with the function
Additional context Appreciate any help, thanks!