Closed ghost closed 3 years ago
You got wrong lyrics because the artist is different on genius (菅野洋子 (Yoko Kanno) ) than it's on spotify (SEATBELTS).
We send query to Genius API with search query being "Cats on Mars - SEATBELTS" and the first (and only) result is Loaded Lux vs. Murda Mook (2003) because it contains word "on Mars" in it's lyrics.
We could do something like this to get better results:
search album by name
find song by title in the album
extract lyrics
I could try to fix this if you want.
Simplicity:
- What can we remove? Is this necessary to most (~80%+) of users?
- Can we make it easier to use? Fewer steps?
Focused Functionality:
- spotDL is to download "content" from Spotify. Does this help doing that? (very narrow focus here people) A.K.A - is this a "need to have"?
- if its a "nice to have", will most of the users use it? (note: its "most users use", not "most users want")
Users first, provided its maintainable:
- Will this do good to the users? They might have not even thought about it, it might make things more complex (more understanding of spotdl required to use it) but will it benefit the majority (~80%+) of them in the process?
- Provided it helps the users, if it has a big impact on maintainability, its still a no-no.
(from spotify-downloader's Core Values)
If there is a feature, it should work properly (as properly as it possibly can) - basically, functionality should be (a) focused and in working condition and (b) good for the users.
Ok it's not possible to search albums by name with genius API. We would have to scrape the website in order to find the needed info, but I don't know if we want to do this. I guess I will drop lyrics if no good matches are found.
Or we could use other lyrics provider, also it's not really allowed to get lyrics they way we do this but idk if we care about this
I was thinking about scraping musixmatch (without the API) -that way we'd inevitably get the correct lyrics
I was thinking about scraping musixmatch (without the API) -that way we'd inevitably get the correct lyrics
We could do that, but I don't think it'd improve the accuracy.
This is why I'm excited for the plugin-based redesign because we would not have to choose between different providers, we could let the user choose which provider to use.
Here's a musixmatch implementation. Could you please test this, if it works better, let me know. Here
We could do that, but I don't think it'd improve the accuracy.
This is why I'm excited for the plugin-based redesign because we would not have to choose between different providers, we could let the user choose which provider to use.
That would happen faster if we had more people working on it simultaneously (which is entirely possible at this point in time). Drop by over spotDl/spotdlRedesign#4
Here's a musixmatch implementation. Could you please test this, if it works better, let me know. Here
Will try ASAP
This issue has been automatically marked stale because there hasn't been any activity for the last 30 days.
Environment
System OS: Windows
Python Version: 3.9
Install Source: dev branch (18/3/21)
Version OR Commit hash: d701f72314884201183eebad5e46e925c34d79c7
Expected Behaviour
spotdl to not get/apply lyrics to cats on mars
Actual Behaviour
Lots of lyrics (explicit ones)
Steps to Reproduce
Traceback
Any other information:
I discovered this while working on #1205