spotDL / spotify-downloader

Download your Spotify playlists and songs along with album art and metadata (from YouTube if a match is found).
https://spotdl.readthedocs.io/en/latest/
MIT License
16.99k stars 1.56k forks source link

"Funky" ASCII song names break "Console UI" & Some broken links #1646

Closed B0N3head closed 1 year ago

B0N3head commented 1 year ago

System OS

Windows

Python Version

3.9 (CPython)

Install Source

pip / PyPi

Install version / commit hash

v4.0.1

Expected Behavior vs Actual Behavior

Expected Progress bar to update smoothly.

Actual Progress bar does not remove previous bar visuals

Steps to reproduce - Ensure to include actual links!

Just run this, I'm assuming that it's just a weird ascii char. spotdl download https://open.spotify.com/track/58o6AY4WfMsGlVrpfsbtGs

Traceback

No proper error log, just a visual glitch. Tho FFMPEG sometimes craps the bed when trying to process this one.
[ffmpeg_error_2022-10-30-21-30-31.txt](https://github.com/spotDL/spotify-downloader/files/9895695/ffmpeg_error_2022-10-30-21-30-31.txt)

Other details

So far I've only had it happen with this song, tho I'm sure other songs with funky chars might throw some errors as well.

B0N3head commented 1 year ago

Another example (not a one off thing)

This album makes the console look corrupted. (Same glitch on all downloading songs causes chaos) spotdl download https://open.spotify.com/album/5CBUobzAmO8mdaFeuG7HJe

B0N3head commented 1 year ago

Wrong song issue

Downloading One Dance by Drake (Command bellow) spotdl download https://open.spotify.com/track/1zi7xx7UVEFkmKfv06H8x0

Results in this video being downloaded (This is some crappy karaoke version with weird synths replacing the lyrics). Video Title: One Dance (In the Style of Drake & Wizkid & Kyla) Channel Name: AVID Karaoke - Topic https://www.youtube.com/watch?v=qtd4T7CNJTE

All my version info is still the same
B0N3head commented 1 year ago

Wrong song issue

Downloading Бом by Antoha MC gives some slow reverb-ed version spotdl download https://open.spotify.com/track/1OdYXTMwjl4f4g4ch05CEq

Info Results
Video Title Антоха МС - Бом (Antoha MC - Bom) [slowed + reverb]
Channel Name Slowed Exotic
YT Link https://www.youtube.com/watch?v=IB3rqKaXZQg
All my version info is still the same

Also... 😅

Why does using the --bitrate 256k output 256kbps files if youtube only outputs 126kbps? Is ffmpeg just re-encoding 126k to 256k?

xnetcat commented 1 year ago

Yup FFmpeg encodes the files to the specified quality.

B0N3head commented 1 year ago

Wrong song issue

Downloading spy? by WHOKILLEDXIX gives the 8-Bit version spotdl download https://open.spotify.com/track/1OdYXTMwjl4f4g4ch05CEq

Info Results
Video Title Spy (8-Bit WHOKILLEDXIX Emulation)
Channel Name 8-Bit Arcade - Topic
YT Link https://www.youtube.com/watch?v=IB3rqKaXZQg

Temp fix spotdl download "https://youtu.be/UlYwnX5DO2Y|https://open.spotify.com/track/0QsZ3W21xNvnUnUMbiAY4z"

All my version info is still the same
B0N3head commented 1 year ago

Horrible bitrate issue

Downloading Twinbow by Slushii consistently outputs a 64kbps song. spotdl download https://open.spotify.com/track/6kUB88CQG4dAOkUmURwBLA

Info Results
Video Title Twinbow
Channel Name Slushii
YT Link https://www.youtube.com/watch?v=_IS-Tvbvjn0

Temp fix (Different Vid) spotdl download "https://youtu.be/Z6IqwhGRP9M|https://open.spotify.com/track/6kUB88CQG4dAOkUmURwBLA"

Are these helpful at all????
xnetcat commented 1 year ago

Song name breaking console ui might actually be an issue in the library that we are using, I am going to open an issue there and we will see what happens.

Thanks for providing the songs that were incorrectly matched, I will try to fix them in the next version, also I've added them to tests so this won't happen in the future.

xnetcat commented 1 year ago

Ok so I've fixed almost all wrongs songs that you've provided. The only one that I can't fix is Drake - One Dance, youtube music refuses to show it in the results when sending requests with ytmusicapi. You can try that by visitng yt music in the incognito mode. image

B0N3head commented 1 year ago

Ok so I've fixed almost all wrongs songs that you've provided. The only one that I can't fix is Drake - One Dance, youtube music refuses to show it in the results when sending requests with ytmusicapi. You can try that by visitng yt music in the incognito mode.

Hey I've got more links, stopped posting them cause I felt like I was spamming them. Is it cool if I put them here (new issue on github) or would discord be easier (the spotdl discord, a thread or channel for reporting, mby even a fancy bot command)?

Yeah tired on multiple devices on different networks for drake. It appears, but only as the [Official video] or something like that (Not the first song I've seen have this issue on yt music). I would image having a community driven list of redirect links (for possible problematic links to the proper music) would not only help with the accuracy of the project (for both finding errors, but also quickly temp patching them without an update using just a redirect) but also would be awesome as a free api to call to (similar to sponserblock).

^^^^^ I'm actually working on something with this idea in mind...

Love your work man 👌

xnetcat commented 1 year ago

Closing this issue because I haven't received response from the rich devs. All the links you provided have been fixed (even drake).

I will reopen this issue once I get response from rich devs