spotDL / spotify-downloader

Download your Spotify playlists and songs along with album art and metadata (from YouTube if a match is found).
https://spotdl.readthedocs.io/en/latest/
MIT License
17.3k stars 1.59k forks source link

Put the synced lyrics in the right tag #1801

Closed Piripe closed 1 year ago

Piripe commented 1 year ago

Requested Feature

Currently, Spotdl put the synced lyrics in the USLT tag, but the right tag for synced lyrics (according to the ID3 documentation https://id3.org/id3v2.3.0#Synchronised_lyrics.2Ftext) is SYLT.

Possible implementation

You could consider synced and unsynced lyrics as two completely different tags, so, you could make possible to save both, synced and unsynced lyrics, in the same file.

xnetcat commented 1 year ago

Code for this is ready. But I've decided not to include it because I couldn't find many clients to test it with, if you know any please let me know.

Piripe commented 1 year ago

I know 2 clients that support synced lyrics, foobar 2000 and MusicBee (I personally tried using foobar 2000 but I also seen someone on Reddit saying that MusicBee supports synced lyrics, but I didn't try it)

Note: In foobar 2000 you have to go in the song properties to see synced lyrics.

xnetcat commented 1 year ago

Ok so I've put synced lyrics to the SYLT tag

MusicBee + MiniLyrics plugin works

image

Foobar2000 doesn't, because foobar2000 doesn't support SYLT tag? idk

xnetcat commented 1 year ago

Either way since v4.1.5 spotdl will write synced lyrics to both USLT and SYLT tags for better compatibility between audio players.

Piripe commented 1 year ago

I just tried it (using the dev branch) and it works perfectly with my phone's main media player (Musicolet)

xnetcat commented 1 year ago

So it didn't work before including SYLT tag? So that means that the SYLT tag does it's job.