spotDL / spotify-downloader

Download your Spotify playlists and songs along with album art and metadata (from YouTube if a match is found).
https://spotdl.readthedocs.io/en/latest/
MIT License
17.48k stars 1.6k forks source link

Setting lyrics provider in web-ui returns duplicate setting #1873

Closed abcdefghijorngarbosaxyz closed 1 year ago

abcdefghijorngarbosaxyz commented 1 year ago

System OS

Windows

Python Version

3.10 (CPython)

Install Source

pip / PyPi

Install version / commit hash

v4.2.0-dev

Expected Behavior vs Actual Behavior

Expected to return a new list of settings with different options set.

Actual behavior returns a list of setting set duplicated.

Steps to reproduce - Ensure to include actual links!

  1. Clone repo locally
  2. Checkout to dev branch
  3. poetry install
  4. poetry shell
  5. spotdl web
  6. In the web-ui, go to settings, and choose a lyrics provider different from genius which is the first one on the list. i.e. musixmatch, azlyrics
  7. Save the settings
  8. Go to the console, and see the log Applying settings followed by a json and see the lyrics provider has duplicate value.

Traceback

INFO:     Applying settings: {'audio_providers': ['youtube'], 'lyrics_providers': ['azlyrics', 'azlyrics', 'musixmatch'], 'playlist_numbering': False, 'scan_for_songs': False, 'm3u': None, 'output': '{artists} - {title}.{output-ext}', 'overwrite': 'skip', 'search_query': None, 'ffmpeg': 'ffmpeg', 'bitrate': None, 'ffmpeg_args': None, 'format': 'mp3', 'save_file': None, 'filter_results': True, 'threads': 4, 'cookie_file': None, 'restrict': 'False', 'print_errors': False, 'sponsor_block': False, 'preload': False, 'archive': None, 'load_config': True, 'log_level': 'INFO', 'simple_tui': True, 'fetch_albums': False, 'id3_separator': '/', 'ytm_data': False, 'add_unavailable': False, 'generate_lrc': False, 'force_update_metadata': False, 'only_verified_results': False, 'sync_without_deleting': False, 'max_filename_length': None, 'yt_dlp_args': None, 'detect_formats': None}

Other details

Logger screenshot

image

abcdefghijorngarbosaxyz commented 1 year ago

Closing this issue as I have traced that the issue is not on spotdl but on the web-ui.

image