spotDL / spotify-downloader

Download your Spotify playlists and songs along with album art and metadata (from YouTube if a match is found).
https://spotdl.readthedocs.io/en/latest/
MIT License
17.03k stars 1.56k forks source link

--playlist-numbering option doesn't seem to have an effect #1895

Closed Karstenve closed 1 year ago

Karstenve commented 1 year ago

System OS

Windows

Python Version

3.11 (CPython)

Install Source

pip / PyPi

Install version / commit hash

v4.2.0.

Expected Behavior vs Actual Behavior

Expected Behavior

I expected each track to gave the playlist's name as it's album and the playlist's icon as the album art.

Actual Behavior

The original album name and album art are applied

Steps to reproduce - Ensure to include actual links!

run in CLI: spotdl download https://open.spotify.com/playlist/06xlbHSZPiTJ5GUklEQVpt?si=1b5c5dd550714ab3 --user-auth --cookie-file music.youtube.com_cookies.txt --output "Music/{title} - {artists}.{output-ext}" --playlist-numbering --id3-separator "\\\\" --profile --log-level DEBUG

Traceback

[15:13:47] DEBUG    MainThread - Downloader settings: {'audio_providers': ['youtube-music'],           downloader.py:128
                    'lyrics_providers': ['genius', 'azlyrics', 'musixmatch'], 'playlist_numbering':
                    True, 'scan_for_songs': False, 'm3u': None, 'output': 'Music/{title} -
                    {artists}.{output-ext}', 'overwrite': 'skip', 'search_query': None, 'ffmpeg':
                    'ffmpeg', 'bitrate': None, 'ffmpeg_args': None, 'format': 'mp3', 'save_file':
                    None, 'filter_results': True, 'threads': 4, 'cookie_file':
                    'music.youtube.com_cookies.txt', 'restrict': None, 'print_errors': False,
                    'sponsor_block': False, 'preload': False, 'archive': None, 'load_config': True,
                    'log_level': 'DEBUG', 'simple_tui': False, 'fetch_albums': False, 'id3_separator':
                    '\\\\', 'ytm_data': False, 'add_unavailable': False, 'generate_lrc': False,
                    'force_update_metadata': False, 'only_verified_results': False,
                    'sync_without_deleting': False, 'max_filename_length': None, 'yt_dlp_args': None,
                    'detect_formats': None}
[15:13:47] DEBUG    MainThread - FFmpeg path: ffmpeg                                                   downloader.py:146
[15:13:47] DEBUG    MainThread - Found 0 known songs                                                   downloader.py:179
[15:13:48] DEBUG    MainThread - Archive: 0 urls                                                       downloader.py:214
[15:13:48] DEBUG    MainThread - Downloader initialized                                                downloader.py:216
[15:13:48] INFO     MainThread - Processing query:                                                         search.py:127
                    https://open.spotify.com/playlist/06xlbHSZPiTJ5GUklEQVpt?si=1b5c5dd550714ab3
[15:13:49] INFO     MainThread - Found 2 songs in TestPlaylist (Playlist)                                  search.py:250
[15:13:49] DEBUG    MainThread - Found 2 songs in 1 lists                                                  search.py:276
[15:13:49] DEBUG    MainThread - Downloading 2 songs                                                   downloader.py:263
[15:13:50] DEBUG    asyncio_1 - Genius failed to find lyrics for The Verve - Bitter Sweet Symphony -   downloader.py:380
                    Remastered 2016
[15:13:51] DEBUG    asyncio_1 - AzLyrics failed to find lyrics for The Verve - Bitter Sweet Symphony - downloader.py:380
                    Remastered 2016
[15:13:51] DEBUG    asyncio_1 - Found lyrics for The Verve - Bitter Sweet Symphony - Remastered 2016   downloader.py:374
                    on MusixMatch
[15:13:51] DEBUG    asyncio_1 - [57iDDD9N9tTWe75x6qhStw] Searching for the verve - bitter sweet symphony -   base.py:167
                    remastered 2016
[15:13:52] DEBUG    asyncio_1 - [57iDDD9N9tTWe75x6qhStw] Found 1 results for ISRC GBUM71601816               base.py:180
[15:13:52] DEBUG    asyncio_1 - [57iDDD9N9tTWe75x6qhStw] Filtered to 1 ISRC results                          base.py:192
[15:13:52] DEBUG    asyncio_1 - [57iDDD9N9tTWe75x6qhStw] Best ISRC result is                                 base.py:201
                    https://music.youtube.com/watch?v=JnRw8bXVbPI with score 86.20689655172413
[15:13:52] DEBUG    asyncio_1 - Downloading The Verve - Bitter Sweet Symphony - Remastered 2016 using  downloader.py:610
                    https://music.youtube.com/watch?v=JnRw8bXVbPI
[15:13:52] DEBUG    asyncio_0 - Found lyrics for Tchami - Adieu on Genius                              downloader.py:374
[15:13:52] DEBUG    asyncio_0 - [62OQBLpD3TmkqbtTPqqdRt] Searching for tchami - adieu                        base.py:167
[15:13:52] DEBUG    asyncio_0 - [62OQBLpD3TmkqbtTPqqdRt] Found 1 results for ISRC USLD91700451               base.py:180
[15:13:52] DEBUG    asyncio_0 - [62OQBLpD3TmkqbtTPqqdRt] Filtered to 0 ISRC results                          base.py:192
[15:13:55] DEBUG    asyncio_0 - [62OQBLpD3TmkqbtTPqqdRt] Found 60 results for search query tchami - adieu    base.py:221
                    with options {'filter': 'songs', 'ignore_spelling': True, 'limit': 50}
[15:13:55] DEBUG    asyncio_0 - [62OQBLpD3TmkqbtTPqqdRt] Best ISRC result is                                 base.py:238
                    https://music.youtube.com/watch?v=3Hq_DQdQkGY
[15:13:55] DEBUG    asyncio_0 - Downloading Tchami - Adieu using                                       downloader.py:610
                    https://music.youtube.com/watch?v=3Hq_DQdQkGY
[15:14:07] INFO     asyncio_1 - Downloaded "The Verve - Bitter Sweet Symphony - Remastered 2016":      downloader.py:773
                    https://music.youtube.com/watch?v=JnRw8bXVbPI
[15:14:12] INFO     asyncio_0 - Downloaded "Tchami - Adieu":                                           downloader.py:773
                    https://music.youtube.com/watch?v=3Hq_DQdQkGY

Other details

No response

0-Kala-0 commented 1 year ago

Same thing here, I'm interested into having a look

xnetcat commented 1 year ago

fixed in 0a692c7b0b0610204908c7823cd14ce078df1b6d

wait for v4.2.1