Don't perform `rglob` every time we check if a file exists. This should be done once in the init function to construct a dict (?)

spotDL / spotify-downloader

Download your Spotify playlists and songs along with album art and metadata (from YouTube if a match is found).

https://spotdl.readthedocs.io/en/latest/

MIT License

17.51k stars 1.61k forks source link

Don't perform `rglob` every time we check if a file exists. This should be done once in the init function to construct a dict (?) #2229

Open Silverarmor opened 1 day ago

Silverarmor commented 1 day ago

I don't think it's good idea to perform rglob every time we check if a file exists. This should be done once in the init function to construct a dict (?)

_Originally posted by @xnetcat in https://github.com/spotDL/spotify-downloader/pull/2214#discussion_r1807445021_

himanshumahajan138 commented 1 day ago

I will update within sone time if anything else required please mention that also