search

spotDL / spotify-downloader

Download your Spotify playlists and songs along with album art and metadata (from YouTube if a match is found).
https://spotdl.readthedocs.io/en/latest/
MIT License
17.34k stars 1.6k forks source link

Suggestion: Manual check mode #32

Closed profucius closed 7 years ago

profucius commented 7 years ago

Loving the script, but I notice that some songs that are named very similarly are getting downloaded incorrectly sometimes. For example:

Song intended to download: Cinnamon Chasers - A New World Song that was downloaded (another one of their songs): Cinnamon Chasers - The World Is Yours

I propose an idea: The script can be started with an option to go into something like a "Manual Mode" that causes it to ask the user at the beginning of each download if the song name it will proceed with downloading is actually correct. If the user replies with (N)o, then the next song in the Youtube list that the script is checking will then be prompted to the user. Upon a (Y)es, the script will proceed as usual, and then prompt on the next song.

This could be useful for getting past those situations where some songs are downloading the ads, or another song by the artist, or even something that is totally unrelated. Does this make sense? I'll clarify if not. Thank you for considering it.

Whacko23 commented 7 years ago

But it beats the purpose of the script: automation. Imagine I have twenty songs in the list. Now just imagine how cumbersome it would be if I have to wait for each song to download so that I have to type yes for next song. This is really a trouble for those who have slow internet connection.

profucius commented 7 years ago

By reading your comment, I believe you might be missing the main point. This is an optional mode that you can be asked when starting the script (or an argument in a shortcut perhaps) that gives you the choice to go automatic as usual, or be manually offered to verify each song.

This would be incredibly useful for example when you have already tried automatic mode, but some songs stubbornly download incorrectly, run it again with just manual mode and it will ask you to verify the song you want to download. If the title of the song does not reflect that from Spotify, then it will pick the next song, and next, until you say Yes.

Again, as an optional feature, it would bridge the gap for an otherwise very annoying process of going to Youtube manually and finding the incorrectly downloaded song, and downloading it by other means.

ritiek commented 7 years ago

Added --manual option to do the same dac66bdd7b92f80caa6d6ae14cd0ccfa130e61fe. Check it out and post any bugs here!

profucius commented 7 years ago

Beautiful, I just tried it and it did ask me for the first song in the list. This method is even better than I had imagined, it lets you choose which song from a list.

However I did find a bug already, I think. I picked the first song manually, and it worked. But then it looks like it skips random songs? It will eventually skip on a song and let me have an option again. I don't see a rhyme or reason so far. Git wont let me upload a screenshot, so below is the code:

C:\Program` Files (x86)\Python27>python.exe spotdl.py --manual -m, --manual choose the song to download manually

Enter a song/cmd: list

Jane X├ÿ - Hard to Forget

Failed to download song. Will retry after other songs.

Televisor - Raindrops - Televisor Remix

  1. Jaël - Raindrops (Televisor Remix) - Duration: 3:53.
  2. Migos - Bad and Boujee ft Lil Uzi Vert [Official Video] - Duration: 5:35.
  3. Nottz Underground - Basement Jaxx Raindrops DUBSTEP Remix (Nottz Underground T.V) - Duration: 3:52.
  4. Levi & Harry D - Raindrops - Duration: 4:07.
  5. Malayalam Medley - Masala Coffee - Music Mojo Season 2 - Kappa TV - Duration: 2:53.
  6. Fytch, Captain Crunch & Carmen Forbes - Raindrops [Official Video HD] - Duration: 3:42.
  7. Raindrops (feat. Kerli) (LinceGamer Remix) - SNBRN | LYRICS! - Duration: 3:16.
  8. Flosstradamus - Drop Top ft. Travis Porter (Party Favor & Meaux Green Remix) - Duration: 3:03.
  9. Enya - Echoes In Rain - Duration: 3:36.
  10. SID THE SCIENCE KID-BAD AND BOUJEE (OFFICIAL VIDEO) - Duration: 1:26.
  11. T-Wayne - Nasty Freestyle (Prismo & CPZ Remix) - Duration: 3:16.
  12. Migos - Bad and Boujee ft. Lil Uzi Vert - Duration: 5:35.
  13. Orlando Brown Describes Raven Symone's Breasts & Their Relationship at 14 - Duration: 9:50.
  14. Ayo & Teo | Rae Sremmurd - Swang || @shmateo_ @ogleloo @kingimprint @richhomiekey - Duration: 3:27.
  15. Childish Gambino - Redbone (Official Audio) - Duration: 5:27.
  16. Niykee Heaton - Bad Intentions ft. Migos - Duration: 4:28.
  17. Big Sean - Bounce Back - Duration: 3:47.
  18. ZIONOV 10 to 100% 11. Episode - Duration: 34:28.
  19. Let's Talk About Junkrat. - Duration: 4:32.
  20. Soul For Real - Candy Rain - Duration: 4:34.

Choose your number: 4

  1. Levi & Harry D - Raindrops 3,920,883 Bytes [100.00%] received. Rate: [9408 KB/s]. ETA: [0 secs] Converting Levi_&_HarryD-_Raindrops.m4a to mp3 Fixing meta-tags WARNING:eyed3.id3.tag:TDEN frame being dropped due to conversion to v2.3

NERO - Circles

  1. Nero - Circles - Duration: 4:32.
  2. Nero - circles - Duration: 4:33.
  3. NERO - Circles [HD] LIVE 10/11/15 - Duration: 4:33.
  4. Circles - Duration: 4:32.
  5. Nero - The Thrill - Duration: 3:35.
  6. Nero - Circles - Duration: 3:32.
  7. Nero Circles @ EDC Orlando 2016 - Duration: 0:36.
  8. Nero - Circles [Ultra Music Festival 2016] - Duration: 3:12.
  9. Nero - Two Minds - Duration: 3:52.
  10. Nero - Between II Worlds - Duration: 7:23.
  11. Nero - Circles (Audio) - Duration: 4:34.
  12. Nero - Won't You Be + Circles (Ultra 2016) - Duration: 6:56.
  13. Nero Part 2 - Circles @ HARD Day of the Dead 2015 [1080P] - Duration: 4:11.
  14. NERO - Circles - Mega DC LIVE - Washington DC - Echostage - 10/17/2015 - Duration: 1:52.
  15. Nero Circles - Duration: 4:32.
  16. Dancing to Nero Circles w/ my Fire Torches - Duration: 4:18.
  17. Audiosurf 2. Nero - Circles (Gameplay) - Duration: 4:42.
  18. Nero - "Circles" drum remix - Duration: 9:09.
  19. Circle of Nero - Duration: 5:31.
  20. Circles - Nero (Live) - Freaknight 2015 - Duration: 1:51.
ritiek commented 7 years ago

It was an encoding error which occured when displaying titles. 2cf0a6f768cfc721b31d296afd838551710fad52 should fix that.

profucius commented 7 years ago

Just got home and tried the fixed script. Went through about 6+ songs just fine. Excellence! I think it's great that the full name and the track length show, that is very helpful when choosing the right one, or even going back and also getting a remix or extended version.

Follow up question: How hard would it be to add to the manual mode an option on songs like "0. Skip this song." ?

Example: I'm batch processing this weeks Discovery Weekly, and notice after the auto script runs that there were just a few songs that came down wrong. I could just paste the playlist into list.txt again, run manual and just skip the unnecessary songs. I'm sure there are other examples, maybe the song you want isn't even in the 20 list, or you see the song and know you already have it in your library.

ritiek commented 7 years ago

Added skip song option in bac6058b2e9b93f2cfb9188d5de9959064b95968