search

spotahome / redis-operator

Redis Operator creates/configures/manages high availability redis with sentinel automatic failover atop Kubernetes.
Apache License 2.0
1.51k stars 358 forks source link

Security context merge #471

Closed samof76 closed 2 years ago

samof76 commented 2 years ago

Fixes #469 .

NOTE: On the contrary might not be good idea to do this is the dest and src securityContext's have conflicting parameters.

@ese what do you think? I am ok either ways.

ese commented 2 years ago

Given the example in the issue, I lean to change the behavior for the proposal. I think it's what a user could expect when they are trying to simply add more options to security-context so they can maintain the default values provided by the operator. I just wondering if we should do this with other fields like affinities.

samof76 commented 2 years ago

I think it's what a user could expect when they are trying to simply add more options to security-context so they can maintain the default values provided by the operator.

@ese But my only concern would be that they would need to really know what the defaults were. It would be going against the kubenetes philosophy of "what you see is what you get". What do you think?

ese commented 2 years ago

@ese But my only concern would be that they would need to really know what the defaults were. It would be going against the Kubernetes philosophy of "what you see is what you get". What do you think?

Make sense. Taking into account that if you are gonna define your own security context you probably are an advanced user who has deep experience with Kubernetes.

samof76 commented 2 years ago

@ese I agree... i will close this.