spotahome / redis-operator

Redis Operator creates/configures/manages high availability redis with sentinel automatic failover atop Kubernetes.
Apache License 2.0
1.5k stars 356 forks source link

Add helm values for rollingUpdate maxUnavailable and maxSurge #516

Closed ben10512 closed 1 year ago

ben10512 commented 1 year ago

Expected behavior

Adding the ability to customize the percentages of maxUnavailable and maxSurge should be added into the helm values file for the sentinal deployment.

Actual behavior

Default values are auto-populated at 25% for both maxUnavailable and maxSurge.

Steps to reproduce the behavior

Complete a base sentinal deployment and describe the deployment to see those values set.

Environment

Recommendation

Given the normal cloud standard 3 zone architecture of data centers (AWS = 1a, 1b, 1c) when the topologySpreadContraint requires zone distribution on scheduling and the rollingUpdate strategy only allows for 25% scale up and unavailable pods are unable to be scheduled because they don't meet the rolling update requirement (when running 3 replicas, 1 per zone).

Enabling the helm values to customize the deployment's maxUnavailable and maxSurge parameters would allow teams to define those values at 35% and enable rolling updates for 3 replica zone distributed systems.

github-actions[bot] commented 1 year ago

This issue is stale because it has been open for 45 days with no activity.

github-actions[bot] commented 1 year ago

This issue was closed because it has been inactive for 14 days since being marked as stale.