Closed lvyanru8200 closed 1 year ago
/cc @ese
@lvyanru8200 this is a chicken and egg issue. So its better to keep it as latest.
@lvyanru8200 this is a chicken and egg issue. So its better to keep it as latest.
you are right
@lvyanru8200 looks good!
It's not a good idea to keep it as latest
, because that way you cannot deploy a certain version by downloading the example from the respective git tag. Furthermore, for people who download the example and deploy it via a CI/CD tool, it will most likely break at some point, because a new version of the operator might require different manifests, e.g., more RBAC permissions. Please note that no other major kubernetes operator vendor puts the latest tag in deployment examples; see, e.g., https://github.com/kubernetes/ingress-nginx/blob/2ea010986f8348b259468506a3118dcc34f54b38/deploy/static/provider/baremetal/deploy.yaml#L452.
Adding to my previous comment: It's not only an issue when deploying via CI/CD. Even when simply restarting the operator on a node where the image is not yet present, it will of course pull the latest
tag. Disaster is inevitable as soon as a new operator version requires different manifests, e.g., more RBAC permissions or a new CRD version.
Signed-off-by: yanru.lv yanru.lv@daocloud.io
Fixes # .
Changes proposed on the PR: