spotahome / redis-operator

Redis Operator creates/configures/manages high availability redis with sentinel automatic failover atop Kubernetes.
Apache License 2.0
1.5k stars 356 forks source link

Wrong template monitoring.yaml #530

Closed brat002 closed 1 year ago

brat002 commented 1 year ago

Expected behaviour

Enabling of monitoring and ServiceMonitor produces wrong manifest.

Actual behaviour

spec:
  ports:
    - port: 9710
      protocol: TCP
      name: metrics
      targetPort: metrics
  selector:
    app.kubernetes.io/name: redis-operator
    app.kubernetes.io/instance: redis---
apiVersion: monitoring.coreos.com/v1

https://github.com/spotahome/redis-operator/blob/master/charts/redisoperator/templates/monitoring.yaml#L26

Steps to reproduce the behaviour

monitoring:
  # Enable Prometheus PodMonitor to monitor the operator.
  enabled: true
  serviceMonitor: true
  serviceAnnotations: {}
  prometheus:
    name: prometheus-operator-xxx

Call helm template.

Environment

Logs

ese commented 1 year ago

Thanks @brat002, Sorry but what is exactly wrong? What is the correct manifest you expect?

github-actions[bot] commented 1 year ago

This issue is stale because it has been open for 45 days with no activity.

github-actions[bot] commented 1 year ago

This issue was closed because it has been inactive for 14 days since being marked as stale.