spotahome / redis-operator

Redis Operator creates/configures/manages high availability redis with sentinel automatic failover atop Kubernetes.
Apache License 2.0
1.49k stars 357 forks source link

Updating configuration for redis #557

Closed basi02 closed 1 year ago

basi02 commented 1 year ago

I am not sure how to be able to update configuration of redis service without removing the pods of the old installation. The update strategy for rfr is onDelete so until we dont remove the old pods, the new updated config pods are not instantiated. Idk how to change the updateStrategy for it to be RollingUpdate?

zekena2 commented 1 year ago

The operator sends the new configs as commands to redis replicas or sentinels. Check here

basi02 commented 1 year ago

Actually wanted to know how to update the configurations like storage and memory and CPU limit etc for the service running in kubernetes. The pods that are installed using helm chart when service is upgraded the pods do not reinstantiate untill we delete the old pods of rfr service

basi02 commented 1 year ago

With the config that you are talking about we can only update these settings I believe?

samagius commented 1 year ago

On line https://github.com/spotahome/redis-operator/blob/fe8090ac7291ee53ac30e534fa1cc03e5759fd10/operator/redisfailover/service/generator.go#L295

Would that be possible to be configurable? If that can be configured from the inputs it would solve out issue.

zekena2 commented 1 year ago

@basi02 Gotcha, I didn't know what configuration are you talking about. the ondelete strategy is on purpose because the operator is the one that handles the deletion of the pods in a smart sequence, first it deletes slaves and then moves to the master after slaves get ready. I've just tested in v1.2.4 after editing cpu limits pods get deleted.

github-actions[bot] commented 1 year ago

This issue is stale because it has been open for 45 days with no activity.

github-actions[bot] commented 1 year ago

This issue was closed because it has been inactive for 14 days since being marked as stale.