spotahome / redis-operator

Redis Operator creates/configures/manages high availability redis with sentinel automatic failover atop Kubernetes.
Apache License 2.0
1.51k stars 359 forks source link

Exporter port is missing on the generated sentinel service #573

Closed taxilian closed 1 year ago

taxilian commented 1 year ago

Expected behaviour

If the sentinel exporter is enabled then the Service should export the metrics port as well as the sentinel port on the generated service -- or at worst it should make another service, but I don't know of any reason it would

Actual behaviour

It creates a service with only one port defined regardless of whether exporter is enabled

Steps to reproduce the behaviour

Create a RedisFailover object with metrics enabled and look at the service

Environment

How are the pieces configured?

I looked at the code and it's not even trying, so I'm pretty confident the rest won't matter =]

github-actions[bot] commented 1 year ago

This issue is stale because it has been open for 45 days with no activity.

github-actions[bot] commented 1 year ago

This issue was closed because it has been inactive for 14 days since being marked as stale.

stocksr commented 1 year ago

/not-stale