search

spotahome / redis-operator

Redis Operator creates/configures/manages high availability redis with sentinel automatic failover atop Kubernetes.
Apache License 2.0
1.49k stars 356 forks source link

Add PodMonitors to configure Prometheus how to monitor Redis and Sentinel pods #624

Open hashemi-soroush opened 1 year ago

hashemi-soroush commented 1 year ago

Fixes #383 , #494 and #623 .

Changes proposed on the PR:

ebuildy commented 1 year ago

Really wonderful! Do you need any help to finish it?

hashemi-soroush commented 1 year ago

Really wonderful! Do you need any help to finish it?

Thanks for the offer. I've tested it on production and it works well. Still, if you have the time, I'd appreciate it if you could review and test it. All comments are welcome.

Also, I've implemented this to resolve the issues mentioned in the PR. If you have similar use cases, please share it in #623 . So we can discuss them and hopefully extend this PR.

EsDmitrii commented 11 months ago

Hi! What about this PR? This is awesome feature, we need this:)

lord-kyron commented 1 month ago

@hashemi-soroush were you able to fix those lastly mentioned problems? I want to merge this PR into our forked repo for this project, but want to make sure those are fixed.

hashemi-soroush commented 1 month ago

Hey @lord-kyron, Unfortunately no. I was working on this PR in my previous company. We were blocked for a while waiting for a code review from the owners, so my team's priorities changed. Soon after, I left the company. Now, I don't have access to a production grade Kubernetes infrastructure. I might be able to fix the issues mentioned in the comments, but I can't test it in a production grade environment. If you can test it, maybe we can finally finish this PR.