Add ability to paste custom annotations to CRD in Helm chart

spotahome / redis-operator

Redis Operator creates/configures/manages high availability redis with sentinel automatic failover atop Kubernetes.

Apache License 2.0

1.49k stars 356 forks source link

Add ability to paste custom annotations to CRD in Helm chart #631

Closed EsDmitrii closed 10 months ago

EsDmitrii commented 1 year ago

Hi! I faced issues when tried to deploy redis-operator via ArgoCD

CustomResourceDefinition.apiextensions.k8s.io "redisfailovers.databases.spotahome.com" is invalid: metadata.annotations: Too long: must have at most 262144 bytes

To fix this issue I need to paste special annotation for ArgoCD. I can't do this via values file, and I need to download chart locally, make changes and deploy. I added ability to add special custom annotations via values.yaml file.

ese commented 10 months ago

Thanks!, Im happy to merge this if you merge with master and fix the conflicts

EsDmitrii commented 10 months ago

@ese Hi! Conflicts are fixed.

liupeng0518 commented 7 months ago

merged this pr has err:

❯ helm upgrade --install redis-operator redis-operator/redis-operator --version 3.3.0                                                                                          ─╯
Error: failed to install CRD crds/databases.spotahome.com_redisfailovers.yaml: error parsing : error converting YAML to JSON: yaml: line 4: did not find expected node content
helm.go:84: [debug] error parsing : error converting YAML to JSON: yaml: line 4: did not find expected node content

sergey-kudriavtsev commented 5 months ago

@EsDmitrii Please check the work

EsDmitrii commented 5 months ago

sorry for the long response, I'm working on it