spotahome / redis-operator

Redis Operator creates/configures/manages high availability redis with sentinel automatic failover atop Kubernetes.
Apache License 2.0
1.49k stars 356 forks source link

CRDs not being installed on chart version v3.3.0 #645

Closed zumic96 closed 8 months ago

zumic96 commented 10 months ago

Expected behaviour

I wanted to install latest version of chart on my clusters.

Actual behaviour

Installation failed with unmarshal error when installing CRD.

Error: failed to install CRD crds/databases.spotahome.com_redisfailovers.yaml: error parsing : error converting YAML to JSON: yaml: line 4: did not find expected node content

Steps to reproduce the behaviour

Run helmfile installation of chart.

helmfile.yaml

repositories:
  - name: redis-operator
    url: https://spotahome.github.io/redis-operator

releases:
  - name: redis-operator
    namespace: redis-operator
    chart: redis-operator/redis-operator
    values:
      - values.yaml

values.yaml

replicas: 2

command used

helmfile apply -f helmfile.yaml

As a workaround added version to helmfile release config

repositories:
  - name: redis-operator
    url: https://spotahome.github.io/redis-operator

releases:
  - name: redis-operator
    namespace: redis-operator
    chart: redis-operator/redis-operator
    version: 3.2.9
    values:
      - values.yaml

Environment

How are the pieces configured?

Logs

Please, add the debugging logs. In order to be able to gather them, add -debug flag when running the operator.

ebuildy commented 10 months ago

I am not sure Helm will template CRD files, hence this is broken from v3.3.0

https://github.com/spotahome/redis-operator/commit/25e69ef986d71928585e3a53b01d6f58b719bcce

ebuildy commented 10 months ago

Also the Docker image tag dont exist https://quay.io/repository/spotahome/redis-operator?tab=tags&tag=latest

zumic96 commented 10 months ago

Can you add mechanism similar to this to skip CRD installation so it can be managed elsewhere i.e. prepare hook of helmfile where it can be installed with kubectl? https://github.com/prometheus-community/helm-charts/blob/main/charts/kube-prometheus-stack/values.yaml#L33

ebuildy commented 10 months ago

I do it right now

Well I am not sure this could help, the kube-prometheus-stack helm chart issue was different.

I did https://github.com/spotahome/redis-operator/pull/651 if you want to have a look.

github-actions[bot] commented 9 months ago

This issue is stale because it has been open for 45 days with no activity.

github-actions[bot] commented 8 months ago

This issue was closed because it has been inactive for 14 days since being marked as stale.