search

spotahome / redis-operator

Redis Operator creates/configures/manages high availability redis with sentinel automatic failover atop Kubernetes.
Apache License 2.0
1.49k stars 356 forks source link

Services exposed to the outside world by default with no option to change it? #647

Closed rafales closed 8 months ago

rafales commented 10 months ago

Expected behavior

I want to deploy a redis service inside my cluster in a safe manner.

Actual behaviour

Redis services are exposed to the outside world via services with type LoadBalancer.

Steps to reproduce the behaviour

Just follow steps in README to deploy the operator, then deploy redisfailover resource.

Environment

AS far as I can see from the source code, there is no way to change this. Operator will deploy a load balancer, which will be accessible form the internet.

image
hashemi-soroush commented 10 months ago

It was added in PR #627 . You can find the reasoning for publicly exposing those services in comments after this. PR #646 changes the service type to ClusterIP until a related configuration is added to the CRD.

github-actions[bot] commented 9 months ago

This issue is stale because it has been open for 45 days with no activity.

github-actions[bot] commented 8 months ago

This issue was closed because it has been inactive for 14 days since being marked as stale.