spotahome / redis-operator

Redis Operator creates/configures/manages high availability redis with sentinel automatic failover atop Kubernetes.
Apache License 2.0
1.48k stars 355 forks source link

if we have k8s watch the redis nodes and expose master service directly, then why we still need sentinels? #671

Closed zeddit closed 5 months ago

zeddit commented 8 months ago

Expected behaviour

remove sentinels by some configurations.

What do you want to achieve?

Actual behaviour

even if I set sentinel to a number of 0, there will still be sentinels.

wusendong commented 7 months ago

If you don't use sentinels, then when the master fails and can't be recovered, then no failover is triggered, and the remaining slaves don't become masters.

zeddit commented 7 months ago

@wusendong great thanks for your help. the problem is that when I want to expose redis service to the outside of the k8s cluster, if I use sentinels, the master IP which sentinels report could not be accessed from the outside of the k8s cluster, because it's a intranet IP, e.g. 10.43.0.0/24

github-actions[bot] commented 6 months ago

This issue is stale because it has been open for 45 days with no activity.

github-actions[bot] commented 5 months ago

This issue was closed because it has been inactive for 14 days since being marked as stale.