search

spotbugs / discuss

SpotBugs mailing list
6 stars 1 forks source link

Release 3.1.2 ? #32

Closed lqc closed 6 years ago

lqc commented 6 years ago

Hi,

I suspect that the issue with @CanIgnoreReturnValue and Guava is troublesome for many users. Maybe it would be worth doing a maintenance release ?

PS. The Sonatype repository has snapshots for 4.0.0 (which is great), but not for 3.1.x versions.

iloveeclipse commented 6 years ago

It would make sense first to finish review of the PR https://github.com/spotbugs/spotbugs/pull/529, which seem to be more or less done. @KengoTODA : I'm right, or is there anything else to do?

After the (hopefully merged) PR above I think we could create 3.1.2. I think the changes we made on 3.1.x are relatively safe. I hoped to spend some time on (internal) testing of the 3.1.x branch, but other higher prio tasks need my attention.

KengoTODA commented 6 years ago

Let me check that PR first.

KengoTODA commented 6 years ago

@iloveeclipse could you check https://github.com/spotbugs/spotbugs/pull/564 and https://github.com/spotbugs/spotbugs/pull/565? If we can merge https://github.com/spotbugs/spotbugs/pull/564 first, then it's better.

iloveeclipse commented 6 years ago

I need some time because I've moved my main system to another PC but I will try to review all PR's this weekend.

iloveeclipse commented 6 years ago

So I've tried to release but failed with travis permissions error, see https://travis-ci.org/spotbugs/spotbugs/jobs/345683682. :-(

KengoTODA commented 6 years ago

rsync: change_dir "/home/travis/build/spotbugs/spotbugs/home/travis/build/spotbugs/spotbugs/eclipsePlugin/build/site/eclipse-candidate" failed: No such file or directory (2)

I think this is not permission error, maybe we need 6f80b4b7254201fac7256fb8b579f216c892ad70 even in release-3.1 branch.

KengoTODA commented 6 years ago

I've proposed https://github.com/spotbugs/spotbugs/pull/569 again, please check @iloveeclipse.

iloveeclipse commented 6 years ago

Many thanks. 3.1.2 is released now.

vorburger commented 6 years ago

@KengoTODA @iloveeclipse thanks! FYI anyone else looking for it, found release notes here:

https://github.com/spotbugs/spotbugs/blob/release-3.1/CHANGELOG.md#312---2018-02-24

iloveeclipse commented 6 years ago

A better link is https://github.com/spotbugs/spotbugs/blob/3.1.2/CHANGELOG.md.

You can reach it via https://github.com/spotbugs/spotbugs -> click on "releases" -> in "SpotBugs 3.1.2 / Changelog" is the link.